You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/06 02:11:13 UTC
Review Request 22294: Allowed net::IP to be created from a dot decimal
string.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22294/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Vinod Kone.
Repository: mesos-git
Description
-------
Added parsing from string. Also, take this chance to refactored the net::IP constructors to properly handle invalid netmasks/prefix.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 97a09a1
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 988b18f
Diff: https://reviews.apache.org/r/22294/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 22294: Allowed net::IP to be created from a dot decimal
string.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22294/#review44941
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/22294/#comment79529>
s/Prefix/Subnet prefix/
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/22294/#comment79530>
s/Prefix/Subnet prefix/
- Vinod Kone
On June 6, 2014, 12:11 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22294/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 12:11 a.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added parsing from string. Also, take this chance to refactored the net::IP constructors to properly handle invalid netmasks/prefix.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 97a09a1
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 988b18f
>
> Diff: https://reviews.apache.org/r/22294/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>