You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by kemitix <gi...@git.apache.org> on 2018/08/17 08:57:58 UTC
[GitHub] brooklyn-ui pull request #62: Restore slf4j.version property
GitHub user kemitix opened a pull request:
https://github.com/apache/brooklyn-ui/pull/62
Restore slf4j.version property
The brooklyn-ui-utils module wouldn't build on a mvn clean install with this property missing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemitix/brooklyn-ui fix-ui-utils-module-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 0f7365b818627ae0fa4c1cdf0fb6a65062d23968
Author: Paul Campbell <pa...@...>
Date: 2018-08-17T08:51:50Z
Restore slf4j.version property
The brooklyn-ui-utils module wouldn't build on a mvn clean install with this
property missing.
----
---
[GitHub] brooklyn-ui issue #62: Restore slf4j.version property
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-ui/pull/62
@ahgittin Retrying build without this fix to confirm if it is needed.
---
[GitHub] brooklyn-ui issue #62: Restore slf4j.version property
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-ui/pull/62
@kemitix We shouldn't have to redeclare it as it can cause different versions of JARs to be pulled in if they get out of sync (which they have here!). It is declared in `brooklyn-server/pom.xml` as `1.7.25` (not `.14` used here), which is the parent of `brooklyn-server/parent/pom.xml` which is the parent of this.
The right fix would be to ensure the ancestor definition is pulled in correctly, which it should be. I am curious why it isn't. I don't see why this would fix it, as the grandparent pom already declares the variable you declare. Suggest re-trying with a clean build on `brooklyn-server` then this (without this fix) and seeing whether it is okay.
---
[GitHub] brooklyn-ui pull request #62: Restore slf4j.version property
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/62
---
[GitHub] brooklyn-ui issue #62: Restore slf4j.version property
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-ui/pull/62
Successfully build from the main `brooklyn` project without this fix in place.
---
[GitHub] brooklyn-ui issue #62: Restore slf4j.version property
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-ui/pull/62
@kemitix can you check ^ and update or close this pls?
---