You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/03 15:51:00 UTC
[jira] [Commented] (ISIS-2476) Remove EntityLinksSelectorPanel, as
is dead code, and allow other implementations of ComponentType.ENTITY to be
picked up.
[ https://issues.apache.org/jira/browse/ISIS-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257788#comment-17257788 ]
ASF subversion and git services commented on ISIS-2476:
-------------------------------------------------------
Commit 9a1b9e41ea858260187bfa1726e7cd0bd7c6a27f in isis's branch refs/heads/ISIS-2476 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9a1b9e4 ]
ISIS-2476: renames classes
> Remove EntityLinksSelectorPanel, as is dead code, and allow other implementations of ComponentType.ENTITY to be picked up.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISIS-2476
> URL: https://issues.apache.org/jira/browse/ISIS-2476
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
> Affects Versions: 2.0.0-M4
> Reporter: Daniel Keir Haywood
> Assignee: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-M5
>
>
> EntityLinksSelectorPanelFactory can actually return either a Bs3GridPanel, or an EntityLinksSelectorPanel. Except it always does the former, and the latter is dead code.
> That means in turn that EntityLinksSelectorPanelFactory is (a) misnamed and (b) should not be given special priority in ComponentFactoryRegisterDefault as a selector ... it should be just another built-in.
> That would then allow other implementations of the ComponentType.ENTITY to be picked up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)