You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 20:12:35 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
rkhachatryan opened a new pull request #13733:
URL: https://github.com/apache/flink/pull/13733
Backport of #13709 to 1.10
## What is the purpose of the change
If checkpoints in ZK are the same as already downloaded then skip
download. This prevents excessive S3 reads and eventually failure to
start the job, particularly in multi-region recovery.
## Verifying this change
Added `testNoDownloadIfCheckpointsNotChanged` and `testDownloadIfCheckpointsChanged` to `ZooKeeperCompletedCheckpointStoreTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13733:
URL: https://github.com/apache/flink/pull/13733#issuecomment-713860477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13733:
URL: https://github.com/apache/flink/pull/13733#issuecomment-713860477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/191536267",
"triggerID" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"triggerType" : "PUSH"
}, {
"hash" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/191545627",
"triggerID" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/191536267)
* d3712e2fae0747cb70322827ed8b82dd6b52ae98 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/191545627)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13733:
URL: https://github.com/apache/flink/pull/13733#issuecomment-713847327
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3 (Wed Oct 21 20:14:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13733:
URL: https://github.com/apache/flink/pull/13733#issuecomment-713860477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/191536267",
"triggerID" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"triggerType" : "PUSH"
}, {
"hash" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/191545627",
"triggerID" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3712e2fae0747cb70322827ed8b82dd6b52ae98 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/191545627)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13733:
URL: https://github.com/apache/flink/pull/13733#issuecomment-713860477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/191536267",
"triggerID" : "1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3",
"triggerType" : "PUSH"
}, {
"hash" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3712e2fae0747cb70322827ed8b82dd6b52ae98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4ff41cb703a3a8ee4d47db5f7008e7ea1ba6b3 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/191536267)
* d3712e2fae0747cb70322827ed8b82dd6b52ae98 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #13733: (1.10 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #13733:
URL: https://github.com/apache/flink/pull/13733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org