You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2021/06/13 21:17:14 UTC
[qpid-broker-j] 02/02: QPID-8535:[Broker-J] Fix attribute name for
'ignoreInvalidSni' and make it derived attribute
This is an automated email from the ASF dual-hosted git repository.
orudyy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-broker-j.git
commit cc51a40b855819e7a0df6f818d9a928a03f11377
Author: Alex Rudyy <or...@apache.org>
AuthorDate: Sun Jun 13 21:51:13 2021 +0100
QPID-8535:[Broker-J] Fix attribute name for 'ignoreInvalidSni' and make it derived attribute
---
.../src/main/java/org/apache/qpid/server/model/port/AmqpPort.java | 4 ++--
.../main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java | 8 ++++----
.../qpid/server/transport/NonBlockingConnectionTLSDelegate.java | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPort.java b/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPort.java
index 68f5683..c2b2e3d 100644
--- a/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPort.java
+++ b/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPort.java
@@ -165,8 +165,8 @@ public interface AmqpPort<X extends AmqpPort<X>> extends Port<X>
@ManagedAttribute( defaultValue = "${" + PORT_MAX_OPEN_CONNECTIONS + "}" )
int getMaxOpenConnections();
- @ManagedAttribute( defaultValue = "${" + PORT_IGNORE_INVALID_SNI + "}" )
- boolean getIgnoreInvalidSni();
+ @DerivedAttribute
+ boolean isIgnoreInvalidSni();
@ManagedStatistic(statisticType = StatisticType.POINT_IN_TIME, units = StatisticUnit.COUNT,
label = "Open Connections",
diff --git a/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java b/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java
index bd7981a..a3b8156 100644
--- a/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java
+++ b/broker-core/src/main/java/org/apache/qpid/server/model/port/AmqpPortImpl.java
@@ -86,9 +86,6 @@ public class AmqpPortImpl extends AbstractPort<AmqpPortImpl> implements AmqpPort
private int _maxOpenConnections;
@ManagedAttributeField
- private boolean _ignoreInvalidSni;
-
- @ManagedAttributeField
private int _threadPoolSize;
@ManagedAttributeField
@@ -112,6 +109,8 @@ public class AmqpPortImpl extends AbstractPort<AmqpPortImpl> implements AmqpPort
private volatile int _tlsSessionTimeout;
private volatile int _tlsSessionCacheSize;
private volatile List<ConnectionPropertyEnricher> _connectionPropertyEnrichers;
+ private volatile boolean _ignoreInvalidSni;
+
@ManagedObjectFactoryConstructor
public AmqpPortImpl(Map<String, Object> attributes, Container<?> container)
@@ -152,7 +151,7 @@ public class AmqpPortImpl extends AbstractPort<AmqpPortImpl> implements AmqpPort
}
@Override
- public boolean getIgnoreInvalidSni()
+ public boolean isIgnoreInvalidSni()
{
return _ignoreInvalidSni;
}
@@ -202,6 +201,7 @@ public class AmqpPortImpl extends AbstractPort<AmqpPortImpl> implements AmqpPort
_heartBeatDelay = getContextValue(Integer.class, AmqpPort.HEART_BEAT_DELAY);
_tlsSessionTimeout = getContextValue(Integer.class, AmqpPort.TLS_SESSION_TIMEOUT);
_tlsSessionCacheSize = getContextValue(Integer.class, AmqpPort.TLS_SESSION_CACHE_SIZE);
+ _ignoreInvalidSni = getContextValue(Boolean.class, AmqpPort.PORT_IGNORE_INVALID_SNI);
@SuppressWarnings("unchecked")
List<String> configurationPropertyEnrichers = getContextValue(List.class, AmqpPort.CONNECTION_PROPERTY_ENRICHERS);
diff --git a/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnectionTLSDelegate.java b/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnectionTLSDelegate.java
index b646d10..869775e 100644
--- a/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnectionTLSDelegate.java
+++ b/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnectionTLSDelegate.java
@@ -81,7 +81,7 @@ public class NonBlockingConnectionTLSDelegate implements NonBlockingConnectionDe
_netInputBuffer = QpidByteBuffer.allocateDirect(_networkBufferSize);
_applicationBuffer = QpidByteBuffer.allocateDirect(_networkBufferSize);
_netOutputBuffer = QpidByteBuffer.allocateDirect(_networkBufferSize);
- _ignoreInvalidSni = port.getIgnoreInvalidSni();
+ _ignoreInvalidSni = port.isIgnoreInvalidSni();
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org