You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mgubaidullin (via GitHub)" <gi...@apache.org> on 2023/07/31 15:49:43 UTC
[GitHub] [camel-karavan] mgubaidullin opened a new issue, #836: Rewrite Karavan Designer to use Functional Components
mgubaidullin opened a new issue, #836:
URL: https://github.com/apache/camel-karavan/issues/836
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Rewrite Karavan Designer to use Functional Components and State [camel-karavan]
Posted by "jasham (via GitHub)" <gi...@apache.org>.
jasham commented on issue #836:
URL: https://github.com/apache/camel-karavan/issues/836#issuecomment-1761326353
Greetings,
This library is very useful. I am using this library for one of my personal projects, but the code and logic are currently written in Typescript and I am trying to convert it to JSX but facing some issues because I am not that good in Typescript. It will be very helpful if the JSX version is available for this.
**Thanks,
Jasham**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #836: Rewrite Karavan Designer to use Functional Components and State
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin closed issue #836: Rewrite Karavan Designer to use Functional Components and State
URL: https://github.com/apache/camel-karavan/issues/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] stefanhuber commented on issue #836: Rewrite Karavan Designer to use Functional Components and State
Posted by "stefanhuber (via GitHub)" <gi...@apache.org>.
stefanhuber commented on issue #836:
URL: https://github.com/apache/camel-karavan/issues/836#issuecomment-1670299405
Ok is there already a branch for that? If you define how, I might be able to help you with some of the components.
Firstly, thank you for providing such a great tool. Some first thoughts/obvservations, which I made when going through the code base:
- It might make sense to create a folder for each component and also add css (instead of one big karavan.css).
- Some components are quite big (e.g, [RestDesigner](https://github.com/apache/camel-karavan/blob/main/karavan-designer/src/designer/rest/RestDesigner.tsx)), it might be possible to split them into smaller ones
- Use 2 spaces for indentation might help ([example](https://github.com/apache/camel-karavan/blob/f6f77ea88b364b6ba7e479327964e1092b4804fc/karavan-designer/src/designer/beans/BeansDesigner.tsx#L130)), it is generally used with javascript
- Adding testing to the component folder directly
- Starting the development server with `npm start` takes a long time, vite would improve this drastically
- It might makes sense to use storybook for developing components in isolation
- Why use react layout components, if the same is possible with css flexbox, just with less code and better performance? ([example](https://github.com/apache/camel-karavan/blob/f6f77ea88b364b6ba7e479327964e1092b4804fc/karavan-designer/src/DesignerPage.tsx#L111))
- One could create a custom hook in react instead of an additional library (`lodash.debounce`) for debounding ([example](https://dev.to/rajeshroyal/how-to-make-a-custom-debounce-hook-in-react-js-4gcc))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #836: Rewrite Karavan Designer to use Functional Components and State
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #836:
URL: https://github.com/apache/camel-karavan/issues/836#issuecomment-1670228248
@stefanhuber yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] stefanhuber commented on issue #836: Rewrite Karavan Designer to use Functional Components and State
Posted by "stefanhuber (via GitHub)" <gi...@apache.org>.
stefanhuber commented on issue #836:
URL: https://github.com/apache/camel-karavan/issues/836#issuecomment-1670225720
Is this process already ongoing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org