You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by "waterWang (via GitHub)" <gi...@apache.org> on 2026/07/28 09:11:16 UTC

[PR] CURATOR-676: Notify CuratorListener for retriable errors when no callback specified [curator]

waterWang opened a new pull request, #1300:
URL: https://github.com/apache/curator/pull/1300

   ## Description
   
   When `abortOperation` is called for a retriable error and no `BackgroundCallback` was specified on the operation, the `CuratorListener` was silently ignored (the method returned early at `if (operation.getCallback() == null) { return; }`).
   
   According to the documented behavior, `CuratorListener` is a catch-all fallback for `BackgroundCallback` when no callback is specified at the operation level. This fix ensures that the `CuratorListener` is properly notified via `processEvent()` in this case.
   
   ## Changes
   
   In `CuratorFrameworkImpl.abortOperation()`:
   - Moved the callback-null check after the event creation
   - When `callback == null`, call `processEvent(event)` to notify all registered `CuratorListener` instances
   - When `callback != null`, continue to call `sendToBackgroundCallback(operation, event)` as before
   
   Fixes #1191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CURATOR-676: Notify CuratorListener for retriable errors when no callback specified [curator]

Posted by "waterWang (via GitHub)" <gi...@apache.org>.
waterWang commented on PR #1300:
URL: https://github.com/apache/curator/pull/1300#issuecomment-5155026342

   Hi maintainers, just a friendly ping — this PR has been open for a while. Could you take a look when you have a moment? Happy to address any feedback. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org