You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Ryan Lubke <Ry...@Sun.COM> on 2002/08/30 06:18:17 UTC
[HttpClient][PATCH] Fix candidate for Bug 11052
Attached is a crack at corrected the bug oulined in 11052
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052)
Basically adds two new methods:
- setDeleteOnRecycle(boolean delete)
- getDeleteOnRecycle()
The primary logic still remains that all temp files created, no matter
what will always be deleted on VM exit, but user can call
setDeleteOnRecycle to true so that when the recycle() method is called
the temp file will be removed.
Thoughts? Comments?
-rl
Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Ryan Lubke <Ry...@Sun.COM>.
I had thought about it, but I didn't really like the idea at the time.
I thought this would be more intuitive.
'course I could be wrong....
Thanks for taking a look. Did you have a chance to look over the new
build.xml patch, or try it out?
On Mon, 2002-09-02 at 05:01, Ortwin Glück wrote:
> Another idea to achieve the same thing:
>
> only add recycle(boolean delete)
>
> the existing recycle() would then just call recycle(false)
>
> This way you can easily control file deletion in place.
>
> Odi
>
> Ryan Lubke wrote:
> > Attached is a crack at corrected the bug oulined in 11052
> > (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052)
> >
> > Basically adds two new methods:
> >
> > - setDeleteOnRecycle(boolean delete)
> > - getDeleteOnRecycle()
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Ortwin Glück <or...@nose.ch>.
Another idea to achieve the same thing:
only add recycle(boolean delete)
the existing recycle() would then just call recycle(false)
This way you can easily control file deletion in place.
Odi
Ryan Lubke wrote:
> Attached is a crack at corrected the bug oulined in 11052
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052)
>
> Basically adds two new methods:
>
> - setDeleteOnRecycle(boolean delete)
> - getDeleteOnRecycle()
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Jeff Dever <js...@sympatico.ca>.
Its great to see the level of cooperation and high quality work in commons in
general and HttpClient in particular. Ryan has been right in there offering
suggestions, accepting criticizisms, participating in discussions and submiting
patches. He's definately a team player and is good to work with.
It will be great to keep working with Ryan as a contributor to HttpClient and we
respect his decision to not have commiter privledges at this time.
Keep it up Ryan!
Ryan Lubke wrote:
> Hi,
>
> I don't know if I'm really allowed input on the vote, but here goes...
>
> While the nomination is very much appreciated, I feel that I haven't
> really contributed enough at this point. I have submitted a few patches
> , but nothing of consequence.
>
> I'm happy working through the bug list and submitting patches for the
> time being.
>
> Thanks again.
>
> -rl
>
> On Fri, 2002-08-30 at 07:12, Michael A. Smith wrote:
> > dion@multitask.com.au wrote:
> > [snip]
> > > I nominate Ryan as a committer on HttpClient..........
> > >
> > >
> > > +1's?
> >
> > try starting a new thread prefixed by [VOTE]. I almost missed this, and
> > I'd bet other committers would as well...
> >
> > +0. Haven't seen quite enough to make an educated decision regarding
> > Ryan...
> >
> > michael
> >
> >
> > --
> > To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> > For additional commands, e-mail: <ma...@jakarta.apache.org>
> >
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Juozas Baliuka <ba...@mwm.lt>.
+1
----- Original Message -----
From: "Davanum Srinivas" <di...@yahoo.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Friday, August 30, 2002 3:48 PM
Subject: Re: [VOTE] Re: [HttpClient][PATCH] Fix candidate for Bug 11052
> +1.
>
> --- Ryan Lubke <Ry...@Sun.COM> wrote:
> > Hi,
> >
> > I don't know if I'm really allowed input on the vote, but here goes...
> >
> > While the nomination is very much appreciated, I feel that I haven't
> > really contributed enough at this point. I have submitted a few patches
> > , but nothing of consequence.
> >
> > I'm happy working through the bug list and submitting patches for the
> > time being.
> >
> > Thanks again.
> >
> > -rl
> >
> >
> >
> >
> >
> > On Fri, 2002-08-30 at 07:12, Michael A. Smith wrote:
> > > dion@multitask.com.au wrote:
> > > [snip]
> > > > I nominate Ryan as a committer on HttpClient..........
> > > >
> > > >
> > > > +1's?
> > >
> > > try starting a new thread prefixed by [VOTE]. I almost missed this,
and
> > > I'd bet other committers would as well...
> > >
> > > +0. Haven't seen quite enough to make an educated decision regarding
> > > Ryan...
> > >
> > > michael
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> > >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
>
>
> =====
> Davanum Srinivas - http://xml.apache.org/~dims/
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Finance - Get real-time stock quotes
> http://finance.yahoo.com
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Davanum Srinivas <di...@yahoo.com>.
+1.
--- Ryan Lubke <Ry...@Sun.COM> wrote:
> Hi,
>
> I don't know if I'm really allowed input on the vote, but here goes...
>
> While the nomination is very much appreciated, I feel that I haven't
> really contributed enough at this point. I have submitted a few patches
> , but nothing of consequence.
>
> I'm happy working through the bug list and submitting patches for the
> time being.
>
> Thanks again.
>
> -rl
>
>
>
>
>
> On Fri, 2002-08-30 at 07:12, Michael A. Smith wrote:
> > dion@multitask.com.au wrote:
> > [snip]
> > > I nominate Ryan as a committer on HttpClient..........
> > >
> > >
> > > +1's?
> >
> > try starting a new thread prefixed by [VOTE]. I almost missed this, and
> > I'd bet other committers would as well...
> >
> > +0. Haven't seen quite enough to make an educated decision regarding
> > Ryan...
> >
> > michael
> >
> >
> > --
> > To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> > For additional commands, e-mail: <ma...@jakarta.apache.org>
> >
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
=====
Davanum Srinivas - http://xml.apache.org/~dims/
__________________________________________________
Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes
http://finance.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[VOTE] Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by Ryan Lubke <Ry...@Sun.COM>.
Hi,
I don't know if I'm really allowed input on the vote, but here goes...
While the nomination is very much appreciated, I feel that I haven't
really contributed enough at this point. I have submitted a few patches
, but nothing of consequence.
I'm happy working through the bug list and submitting patches for the
time being.
Thanks again.
-rl
On Fri, 2002-08-30 at 07:12, Michael A. Smith wrote:
> dion@multitask.com.au wrote:
> [snip]
> > I nominate Ryan as a committer on HttpClient..........
> >
> >
> > +1's?
>
> try starting a new thread prefixed by [VOTE]. I almost missed this, and
> I'd bet other committers would as well...
>
> +0. Haven't seen quite enough to make an educated decision regarding
> Ryan...
>
> michael
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by "Michael A. Smith" <ma...@apache.org>.
dion@multitask.com.au wrote:
[snip]
> I nominate Ryan as a committer on HttpClient..........
>
>
> +1's?
try starting a new thread prefixed by [VOTE]. I almost missed this, and
I'd bet other committers would as well...
+0. Haven't seen quite enough to make an educated decision regarding
Ryan...
michael
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by "Craig R. McClanahan" <cr...@apache.org>.
Nonbinding (i.e. non-HttpClient committer) +1 from me.
Craig
On Fri, 30 Aug 2002 dion@multitask.com.au wrote:
> Date: Fri, 30 Aug 2002 15:29:31 +1000
> From: dion@multitask.com.au
> Reply-To: Jakarta Commons Developers List <co...@jakarta.apache.org>
> To: Jakarta Commons Developers List <co...@jakarta.apache.org>
> Subject: Re: [HttpClient][PATCH] Fix candidate for Bug 11052
>
> Ryan Lubke <Ry...@Sun.COM> wrote on 30/08/2002 02:18:17 PM:
>
> > Attached is a crack at corrected the bug oulined in 11052
> > (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052)
> >
> > Basically adds two new methods:
> >
> > - setDeleteOnRecycle(boolean delete)
> > - getDeleteOnRecycle()
> >
> > The primary logic still remains that all temp files created, no matter
> > what will always be deleted on VM exit, but user can call
> > setDeleteOnRecycle to true so that when the recycle() method is called
> > the temp file will be removed.
> >
> > Thoughts? Comments?
>
> I nominate Ryan as a committer on HttpClient..........
>
>
> +1's?
> --
> dIon Gillard, Multitask Consulting
> Work: http://www.multitask.com.au
> Developers: http://adslgateway.multitask.com.au/developers
>
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient][PATCH] Fix candidate for Bug 11052
Posted by di...@multitask.com.au.
Ryan Lubke <Ry...@Sun.COM> wrote on 30/08/2002 02:18:17 PM:
> Attached is a crack at corrected the bug oulined in 11052
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052)
>
> Basically adds two new methods:
>
> - setDeleteOnRecycle(boolean delete)
> - getDeleteOnRecycle()
>
> The primary logic still remains that all temp files created, no matter
> what will always be deleted on VM exit, but user can call
> setDeleteOnRecycle to true so that when the recycle() method is called
> the temp file will be removed.
>
> Thoughts? Comments?
I nominate Ryan as a committer on HttpClient..........
+1's?
--
dIon Gillard, Multitask Consulting
Work: http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>