You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:43:39 UTC

[GitHub] [echarts-doc] pe-3 opened a new pull request, #281: feat(funnel): add funnel new styles and props

pe-3 opened a new pull request, #281:
URL: https://github.com/apache/echarts-doc/pull/281

   [related pull request #14863](https://github.com/apache/echarts/pull/17461)
   - [x]  feat(funnel): set prop to flatten the funnel exit.
   - [x]  feat(funnel): set prop to make funnel piece height dynamic.
   - [ ]  feat(funnel): set prop to control funnel exit width if dynamcHeight is true. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts-doc] Ovilia commented on a diff in pull request #281: feat(funnel): add funnel new styles and props

Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #281:
URL: https://github.com/apache/echarts-doc/pull/281#discussion_r953283450


##########
zh/option/series/funnel.md:
##########
@@ -86,6 +86,32 @@ option = {
 
 数据排序， 可以取 `'ascending'`，`'descending'`，`'none'`（表示按 data 顺序），或者一个函数（即 `Array.prototype.sort(function (a, b) { ... })`）。
 
+## exitShape(string) = 'none'
+
+<ExampleUIControlEnum options="none,rect" default="none" />
+
+漏斗出口形状, 设为 `'rect'` 来展平顶部。
+
+## dynamicHeight(boolean)
+
+<ExampleUIControlEnum options="true,false" default="false" />
+
+设置为`true`使得漏斗图每个漏斗块的高度和数据集对应数值成正比。
+
+## exitWidth(string)
+
+<ExampleUIControlPercent default="0%" />
+
+当dynamicHeight为`true`时，控制出口宽度占入口宽度多少，设置exitWidth可以使图形更接近漏斗形状，而非尖底的金字塔形状。<br/>
+当dynamicHeight为不为true并且showRate为`true`时，控制出口为一个梯形，即出口块上底边是下底边多少。<br/>

Review Comment:
   Add links for these options.
   No `<br/>`. Please use an empty line for paragraph breaking.



##########
en/option/series/funnel.md:
##########
@@ -24,27 +24,27 @@
 
 <ExampleUIControlNumber default="0" step="1" />
 
-The specified minimum value.
+The specified minimum value. Invalid if dynamicHeight is `true`.

Review Comment:
   `dynamicHeight` should add link



##########
zh/option/series/funnel.md:
##########
@@ -86,6 +86,32 @@ option = {
 
 数据排序， 可以取 `'ascending'`，`'descending'`，`'none'`（表示按 data 顺序），或者一个函数（即 `Array.prototype.sort(function (a, b) { ... })`）。
 
+## exitShape(string) = 'none'
+
+<ExampleUIControlEnum options="none,rect" default="none" />
+
+漏斗出口形状, 设为 `'rect'` 来展平顶部。
+
+## dynamicHeight(boolean)
+
+<ExampleUIControlEnum options="true,false" default="false" />
+
+设置为`true`使得漏斗图每个漏斗块的高度和数据集对应数值成正比。
+
+## exitWidth(string)
+
+<ExampleUIControlPercent default="0%" />
+
+当dynamicHeight为`true`时，控制出口宽度占入口宽度多少，设置exitWidth可以使图形更接近漏斗形状，而非尖底的金字塔形状。<br/>
+当dynamicHeight为不为true并且showRate为`true`时，控制出口为一个梯形，即出口块上底边是下底边多少。<br/>
+exitWidht必须是百分比格式的字符串，而且不能超过99%。

Review Comment:
   Why 99%? This seems strange.



##########
zh/option/series/funnel.md:
##########
@@ -86,6 +86,32 @@ option = {
 
 数据排序， 可以取 `'ascending'`，`'descending'`，`'none'`（表示按 data 顺序），或者一个函数（即 `Array.prototype.sort(function (a, b) { ... })`）。
 
+## exitShape(string) = 'none'
+
+<ExampleUIControlEnum options="none,rect" default="none" />
+
+漏斗出口形状, 设为 `'rect'` 来展平顶部。
+
+## dynamicHeight(boolean)
+
+<ExampleUIControlEnum options="true,false" default="false" />
+
+设置为`true`使得漏斗图每个漏斗块的高度和数据集对应数值成正比。
+
+## exitWidth(string)
+
+<ExampleUIControlPercent default="0%" />
+
+当dynamicHeight为`true`时，控制出口宽度占入口宽度多少，设置exitWidth可以使图形更接近漏斗形状，而非尖底的金字塔形状。<br/>
+当dynamicHeight为不为true并且showRate为`true`时，控制出口为一个梯形，即出口块上底边是下底边多少。<br/>
+exitWidht必须是百分比格式的字符串，而且不能超过99%。

Review Comment:
   Typo. `exitWidht` should be `exitWidth`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts-doc] Ovilia commented on a diff in pull request #281: feat(funnel): add funnel new styles and props

Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #281:
URL: https://github.com/apache/echarts-doc/pull/281#discussion_r953286836


##########
zh/option/series/funnel.md:
##########
@@ -86,6 +86,32 @@ option = {
 
 数据排序， 可以取 `'ascending'`，`'descending'`，`'none'`（表示按 data 顺序），或者一个函数（即 `Array.prototype.sort(function (a, b) { ... })`）。
 
+## exitShape(string) = 'none'
+
+<ExampleUIControlEnum options="none,rect" default="none" />
+
+漏斗出口形状, 设为 `'rect'` 来展平顶部。
+
+## dynamicHeight(boolean)
+
+<ExampleUIControlEnum options="true,false" default="false" />
+
+设置为`true`使得漏斗图每个漏斗块的高度和数据集对应数值成正比。
+
+## exitWidth(string)
+
+<ExampleUIControlPercent default="0%" />
+
+当dynamicHeight为`true`时，控制出口宽度占入口宽度多少，设置exitWidth可以使图形更接近漏斗形状，而非尖底的金字塔形状。<br/>
+当dynamicHeight为不为true并且showRate为`true`时，控制出口为一个梯形，即出口块上底边是下底边多少。<br/>
+exitWidht必须是百分比格式的字符串，而且不能超过99%。
+
+## showRate(boolean)
+
+<ExampleUIControlEnum options="true,false" default="false" />
+
+在dynamicHeight为`false`时，设置为`true`使得漏斗图展示每个相邻数据的转化率和总体转化率。

Review Comment:
   这个表达有点不太好理解，”使得漏斗图“的表述有点模糊，是指在 label 上显示吗？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts-doc] pissang merged pull request #281: feat(funnel): add funnel new styles and props

Posted by GitBox <gi...@apache.org>.
pissang merged PR #281:
URL: https://github.com/apache/echarts-doc/pull/281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org