You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/28 13:17:56 UTC

[GitHub] [pulsar-client-go] rueian commented on a change in pull request #248: Clean callbacks of connection after run loop stopped (#239)

rueian commented on a change in pull request #248:
URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r446650041



##########
File path: pulsar/internal/connection.go
##########
@@ -656,20 +662,14 @@ func (c *connection) Close() {
 
 	c.log.Info("Connection closed")
 	c.state = connectionClosed
-	if c.cnx != nil {
-		c.cnx.Close()
-	}
+	c.TriggerClose()

Review comment:
       This method is wrapped with a mutex and a `c.state == connectionClosed` check.
   I think another call to `Close()` will have no effect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org