You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/27 11:37:17 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4740: Cleanup InformationSchema plumbing
tustvold opened a new pull request, #4740:
URL: https://github.com/apache/arrow-datafusion/pull/4740
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This follows on from #4606 and #4722 and simplifies the handling of information schema
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4740: Cleanup InformationSchema plumbing
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4740:
URL: https://github.com/apache/arrow-datafusion/pull/4740#issuecomment-1365898050
Benchmark runs are scheduled for baseline = 9046a8aca5b9978b3f4d57a658d61c3ede06b029 and contender = 8c0c0ad3d786d3c0799b602bb12c0b15e4009f12. 8c0c0ad3d786d3c0799b602bb12c0b15e4009f12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/efa7eaf8fc2d443b9c4cb3039c594833...d93582a29aa64227b813cf431ca384eb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/884024e334784fed9728f3aa1ed95a58...432cb30e15364c9f90a6ff556dd7a88e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7fa2097b20354bebbdf1c22b86f65353...d88b8ac0ee80421ea31f3c6bf26a9c6a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/044ed610b08e421ba67ff1a9971977a7...5a5805295d684ab59e819a9d2fc0d3e6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4740: Cleanup InformationSchema plumbing
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4740:
URL: https://github.com/apache/arrow-datafusion/pull/4740#discussion_r1057656363
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1721,6 +1653,12 @@ impl SessionState {
table_ref: impl Into<TableReference<'a>>,
) -> Result<Arc<dyn SchemaProvider>> {
let resolved_ref = self.resolve_table_ref(table_ref);
+ if self.config.information_schema() && resolved_ref.schema == INFORMATION_SCHEMA {
+ return Ok(Arc::new(InformationSchemaProvider::new(
Review Comment:
This is cool -- it makes the information schema provider on demand 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #4740: Cleanup InformationSchema plumbing
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #4740:
URL: https://github.com/apache/arrow-datafusion/pull/4740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4740: Cleanup InformationSchema plumbing
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #4740:
URL: https://github.com/apache/arrow-datafusion/pull/4740#discussion_r1057627960
##########
datafusion/core/src/catalog/mod.rs:
##########
@@ -20,7 +20,7 @@
#![allow(clippy::module_inception)]
pub mod catalog;
-pub mod information_schema;
+pub(crate) mod information_schema;
Review Comment:
There wasn't anything public in the module so we might as well just make it crate private
https://docs.rs/datafusion/latest/datafusion/catalog/information_schema/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org