You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2025/09/17 16:45:50 UTC
[PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Aggarwal-Raghav opened a new pull request, #63:
URL: https://github.com/apache/hive-site/pull/63
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #63:
URL: https://github.com/apache/hive-site/pull/63#issuecomment-3307715977
These are still left even with this PR.
<img width="1509" height="569" alt="Screenshot 2025-09-18 at 7 45 57 PM" src="https://github.com/user-attachments/assets/43d43493-fc92-421b-9e15-163352326a9f" />
Except config.toml I don't think we need to change as they are not hive specific.
Can you please review @zabetak @thomasrebele
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #63:
URL: https://github.com/apache/hive-site/pull/63#issuecomment-3317980975
Thanks for the PR @Aggarwal-Raghav and @thomasrebele for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak merged PR #63:
URL: https://github.com/apache/hive-site/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on PR #63:
URL: https://github.com/apache/hive-site/pull/63#issuecomment-3309847766
Thank you @Aggarwal-Raghav for fixing the remaining links! LGTM. Maybe we can just remove the precommit link in the config.toml? Together with the link in the navbar (Development > Precommit Patch Testing): https://github.com/apache/hive-site/blob/17d1cc6cea1fcc531835b1d0cb63947a2aefb3b5/themes/hive/layouts/partials/menu.html#L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29102: (Addendum) Fix leftover cwiki links [hive-site]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #63:
URL: https://github.com/apache/hive-site/pull/63#issuecomment-3319759619
> LGTM, will merge soon!
>
> Below a small general advice (that I forgot to mention in the previous PR about HIVE-29102) and is relevant for future contributions to hive-site repo.
>
> In general, is it best to avoid harcoding absolute URLs to `https://hive.apache.org` whenever possible. These URLs cannot be verified by Hugo and can easily go stale/break without anyone noticing. Using the `< ref >` directives can avoid this problem so it should be the prefferred way of adding links.
>
> Absolute URLs, also make testing more difficult since when you preview the site locally some clicks will use the local version and some others will take you to the actual deployed version online.
ACK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org