You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/23 16:29:53 UTC

[GitHub] [arrow-rs] tfeda commented on issue #1554: Improve ergonomics of `parquet::basic::LogicalType`

tfeda commented on issue #1554:
URL: https://github.com/apache/arrow-rs/issues/1554#issuecomment-1107530472

   Hi all, I've started implementing this. Would we want the string parser to also use CamelCase?
   for example: 
   ```
   let message = " 
   message test_schema {
       REQUIRED INT32   uint8 (INTEGER(8,false));
       REQUIRED INT32   uint16 (INTEGER(16,false));
   } 
   "
   ```
   would be changed to
   
   ```
   let message = " 
   message test_schema {
       REQUIRED INT32   uint8 (Integer(8,false));
       REQUIRED INT32   uint16 (Integer(16,false));
   } 
   "
   ```
   I originally came across this when starting to edit error messages, and wasn't sure if printing the enum's format or the string's format is more instructive to the user.
   
   Ex:
   `general_err!("Failed to parse timeunit for Timestamp type")`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org