[GitHub] [nifi] mcgilman commented on a change in pull request #3990: NIFI-7032 Processor Details no longer appears when clicking 'View Processor Details'

[GitBox <gi...@apache.org>]

mcgilman commented on a change in pull request #3990: NIFI-7032 Processor Details no longer appears when clicking 'View Processor Details'
URL: https://github.com/apache/nifi/pull/3990#discussion_r368080480
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
 ##########
 @@ -179,6 +179,9 @@
                 readOnly: true,
                 getParameterContext: function (groupId) {
                     // processors being configured must be in the current group
+                    if(typeof nfCanvasUtils === "undefined"){
 
 Review comment:
   Rather than conditionally returning null, can we update this to conditional populate `getParameterContext`. This would offer a minor performance improvement as the `getParameterContext` configuration option is optional. By only populating `getParameterContext` when `nfCanvasUtils` is available we will avoid two calls into `getParameterContext` for every row in the table.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services