You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/08 14:50:43 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5442: drivers/mtd/mtd_config.c: enlarge the limits of blocksize in struct m…

xiaoxiang781216 commented on a change in pull request #5442:
URL: https://github.com/apache/incubator-nuttx/pull/5442#discussion_r801715947



##########
File path: drivers/mtd/mtd_config.c
##########
@@ -77,7 +77,7 @@ struct mtdconfig_struct_s
 {
   FAR struct mtd_dev_s *mtd;  /* Contained MTD interface */
   sem_t        exclsem;       /* Supports mutual exclusion */
-  uint32_t     blocksize :14; /* Size of blocks in contained MTD */
+  uint32_t     blocksize :18; /* Size of blocks in contained MTD */
   uint32_t     erasesize :18; /* Size of erase block  in contained MTD */

Review comment:
       why not remove 14/18 from the struct directly? with your change, we always need 64bits storage now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org