You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/10/22 22:41:46 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1200: SAMZA-2360 : Adding config stores.init.clean to clean all store-dirs on init, regardless of contents

rmatharu commented on a change in pull request #1200: SAMZA-2360 : Adding config stores.init.clean to clean all store-dirs on init, regardless of contents
URL: https://github.com/apache/samza/pull/1200#discussion_r337781868
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/storage/NonTransactionalStateTaskRestoreManager.java
 ##########
 @@ -110,20 +110,21 @@
    */
   @Override
   public void init(Map<SystemStreamPartition, String> checkpointedChangelogSSPOffsets) {
-    cleanBaseDirsAndReadOffsetFiles();
+    cleanBaseDirsAndReadOffsetFiles(new StorageConfig(config).getCleanLoggedStoreDirsOnInit());
 
 Review comment:
   The TransactionalStateTaskRestoreManager already seems to delete storeDirs on start after reading?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services