[GitHub] [cordova-ios] brodybits opened a new issue #826: internal *-Info.plist filter behavior not properly tested

[GitBox <gi...@apache.org>]

brodybits opened a new issue #826: internal *-Info.plist filter behavior not properly tested
URL: https://github.com/apache/cordova-ios/issues/826
 
 
   From review of changes that were proposed in PR #765, I discovered that the following change would not cause a test failure:
   
   ```diff
   diff --git a/bin/templates/scripts/cordova/lib/projectFile.js b/bin/templates/scripts/cordova/lib/projectFile.js
   index 35a5a917..6ab43422 100644
   --- a/bin/templates/scripts/cordova/lib/projectFile.js
   +++ b/bin/templates/scripts/cordova/lib/projectFile.js
   @@ -41,7 +41,7 @@ function parseProjectFile (locations) {
        xcodeproj.parseSync();
    
        const xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
   -    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings && entry.buildSettings.INFOPLIST_FILE);
   +    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings);
        const plist_file = path.join(project_dir, plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^"(.*)"$/g, '$1').replace(/\\&/g, '&'));
        const config_file = path.join(path.dirname(plist_file), 'config.xml');
    
   ```
   
   Considering that this internal filter needs to be adapted to resolve issue #764, I would conclude that this indicates a missing test case.
   
   This should be part of the list of plist/config.xml issues in #793. At this point I am unsure whether these issues are all the same or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org