You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2014/12/31 18:13:02 UTC

Struts 2.3.21 ready for test

Hi,

Please take a time and test the bits - any help is appreciated. Please
report back any problems. I'll call for vote in a week if no problems
will be spotted.

Staging Maven repo
https://repository.apache.org/content/groups/staging/

Standalone artifacts
https://dist.apache.org/repos/dist/dev/struts/2.3.21/

Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21


Happy New Year!
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Mi...@silbergrau.com.
Looks good +1



From:   Lukasz Lenart <lu...@apache.org>
To:     Struts Developers List <de...@struts.apache.org>
Date:   01/07/2015 03:02 PM
Subject:        Re: Struts 2.3.21 ready for test



2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.3.21/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21

Anyone would like to test and post comments?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Lukasz Lenart <lu...@apache.org>.
2015-01-08 10:22 GMT+01:00 Christoph Nenning <Ch...@lex-com.net>:
> Has voting already started ?
>
> if so: +1 nb

Not yet, will open it soon

> In case you missed it: I posted on friday that it was good in my tests.

Yes, noticed that! Thanks a lot!


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Johannes Geppert <jo...@apache.org>.
Hi Christoph,

no voting has not started. Voting for new release always start in a new
mail thread after the test period.


Best Regards

Johannes

#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep


2015-01-08 10:22 GMT+01:00 Christoph Nenning <Ch...@lex-com.net>
:

> Has voting already started ?
>
> if so: +1 nb
>
> In case you missed it: I posted on friday that it was good in my tests.
>
>
>
> regards,
> Christoph
>
>
>
> > 2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> > > Hi,
> > >
> > > Please take a time and test the bits - any help is appreciated. Please
> > > report back any problems. I'll call for vote in a week if no problems
> > > will be spotted.
> > >
> > > Staging Maven repo
> > > https://repository.apache.org/content/groups/staging/
> > >
> > > Standalone artifacts
> > > https://dist.apache.org/repos/dist/dev/struts/2.3.21/
> > >
> > > Release notes
> > > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
> >
> > Anyone would like to test and post comments?
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
> This Email was scanned by Sophos Anti Virus
>

Re: Struts 2.3.21 ready for test

Posted by Christoph Nenning <Ch...@lex-com.net>.
Has voting already started ?

if so: +1 nb

In case you missed it: I posted on friday that it was good in my tests.



regards,
Christoph



> 2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> > Hi,
> >
> > Please take a time and test the bits - any help is appreciated. Please
> > report back any problems. I'll call for vote in a week if no problems
> > will be spotted.
> >
> > Staging Maven repo
> > https://repository.apache.org/content/groups/staging/
> >
> > Standalone artifacts
> > https://dist.apache.org/repos/dist/dev/struts/2.3.21/
> >
> > Release notes
> > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
> 
> Anyone would like to test and post comments?
> 
> 
> Regards
> -- 
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
> 

This Email was scanned by Sophos Anti Virus

Re: Struts 2.3.21 ready for test

Posted by Greg Huber <gr...@gmail.com>.
Looks good.  +1 nb.

Cheers Greg.

On 7 January 2015 at 14:01, Lukasz Lenart <lu...@apache.org> wrote:

> 2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> > Hi,
> >
> > Please take a time and test the bits - any help is appreciated. Please
> > report back any problems. I'll call for vote in a week if no problems
> > will be spotted.
> >
> > Staging Maven repo
> > https://repository.apache.org/content/groups/staging/
> >
> > Standalone artifacts
> > https://dist.apache.org/repos/dist/dev/struts/2.3.21/
> >
> > Release notes
> > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
>
> Anyone would like to test and post comments?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Re: Struts 2.3.21 ready for test

Posted by Volker Krebs <vo...@abas.de>.
Am 07.01.2015 um 15:01 schrieb Lukasz Lenart:
> 2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
>> Hi,
>>
>> Please take a time and test the bits - any help is appreciated. Please
>> report back any problems. I'll call for vote in a week if no problems
>> will be spotted.
>>
>> Staging Maven repo
>> https://repository.apache.org/content/groups/staging/
>>
>> Standalone artifacts
>> https://dist.apache.org/repos/dist/dev/struts/2.3.21/
>>
>> Release notes
>> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
>
> Anyone would like to test and post comments?
>
My tests passed :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Lukasz Lenart <lu...@apache.org>.
2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.3.21/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21

Anyone would like to test and post comments?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Lukasz Lenart <lu...@apache.org>.
2015-01-02 12:31 GMT+01:00 Johannes Geppert <jo...@apache.org>:
> But maybe creating a section in the Convention Plugin Documentation how to
> enable/fix problems with Lambda Expression is enough?

Maybe you're right, but I would like to hear other's opinion,
especially users using 2.3.20 with Java 8 and CXF (the original
reports for that issue)

> Creating a plugin which fix a JDK related problem of another plugin and
> mark it as deprecated at the same time when introducing it feels wrong to
> me.

There are few other issues here - first we already introduced support
for Java 8 with 2.3.20, now throwing it away can harm people (but
maybe the note in the docs is a sufficient solution). Another thing is
that we're using ASM in very limited way and maybe there is a better
approach without ASM (I thought about
https://code.google.com/p/reflections/ instead) - if with drop ASM,
such plugin won't be needed anymore and we can deprecate it.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Johannes Geppert <jo...@apache.org>.
But maybe creating a section in the Convention Plugin Documentation how to
enable/fix problems with Lambda Expression is enough?

Creating a plugin which fix a JDK related problem of another plugin and
mark it as deprecated at the same time when introducing it feels wrong to
me.


Best Regards

Johannes

#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep


2015-01-02 11:18 GMT+01:00 Lukasz Lenart <lu...@apache.org>:

> 2015-01-02 11:04 GMT+01:00 Johannes Geppert <jo...@apache.org>:
> > Hi,
> >
> > thanks Lukasz for preparing this new release. One question to the new
> Java8
> > Plugin.
> > Is this a real use case for creating a official plugin we want to support
> > in future?
> >
> > I mean it is a fix for the convention plugin in a specific JDK version.
> > Developers are maybe are confused when later Java9 or Java1X is released.
> >
> > Is it not better to move this logic directly to the convention plugin and
> > name it like LambdaExpressionClassFinder or something similar?
>
> The problem is with dependencies - you cannot have two the same
> dependencies but with different versions, it won't compile :( I
> started with this approach but because of classpath conflicts I had to
> move this into the plugin. Compare the dependencies:
>
> XWork
> https://github.com/apache/struts/blob/develop/xwork-core/pom.xml#L128-L135
>
> Plugin
>
> https://github.com/apache/struts/blob/develop/plugins/java8-support/pom.xml#L33-L46
>
> Both ASM dependencies defined in parent
> https://github.com/apache/struts/blob/develop/pom.xml#L590-L609
>
> It wouldn't have been a problem if ASM had used different package
> names, the same as we use for S1 and S2 - now you end up with class
> name clash :|
>
> I'm not sure if this is the right approach - but it was the best
> possible idea and we can throw it away in S2.5 or just drop the plugin
> and tell people how to add support for Java8 (you must implement
> interface and that's all)
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Re: Struts 2.3.21 ready for test

Posted by Lukasz Lenart <lu...@apache.org>.
2015-01-02 11:04 GMT+01:00 Johannes Geppert <jo...@apache.org>:
> Hi,
>
> thanks Lukasz for preparing this new release. One question to the new Java8
> Plugin.
> Is this a real use case for creating a official plugin we want to support
> in future?
>
> I mean it is a fix for the convention plugin in a specific JDK version.
> Developers are maybe are confused when later Java9 or Java1X is released.
>
> Is it not better to move this logic directly to the convention plugin and
> name it like LambdaExpressionClassFinder or something similar?

The problem is with dependencies - you cannot have two the same
dependencies but with different versions, it won't compile :( I
started with this approach but because of classpath conflicts I had to
move this into the plugin. Compare the dependencies:

XWork
https://github.com/apache/struts/blob/develop/xwork-core/pom.xml#L128-L135

Plugin
https://github.com/apache/struts/blob/develop/plugins/java8-support/pom.xml#L33-L46

Both ASM dependencies defined in parent
https://github.com/apache/struts/blob/develop/pom.xml#L590-L609

It wouldn't have been a problem if ASM had used different package
names, the same as we use for S1 and S2 - now you end up with class
name clash :|

I'm not sure if this is the right approach - but it was the best
possible idea and we can throw it away in S2.5 or just drop the plugin
and tell people how to add support for Java8 (you must implement
interface and that's all)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Struts 2.3.21 ready for test

Posted by Johannes Geppert <jo...@apache.org>.
Hi,

thanks Lukasz for preparing this new release. One question to the new Java8
Plugin.
Is this a real use case for creating a official plugin we want to support
in future?

I mean it is a fix for the convention plugin in a specific JDK version.
Developers are maybe are confused when later Java9 or Java1X is released.

Is it not better to move this logic directly to the convention plugin and
name it like LambdaExpressionClassFinder or something similar?


Best Regards

Johannes

#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep


2014-12-31 18:13 GMT+01:00 Lukasz Lenart <lu...@apache.org>:

> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.3.21/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
>
>
> Happy New Year!
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Re: Struts 2.3.21 ready for test

Posted by Christoph Nenning <Ch...@lex-com.net>.
> Hi,
> 
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
> 
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
> 
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.3.21/
> 
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.21
> 
> 
> Happy New Year!

Happy New Year Everybody !


Tested it with my apps -> looks good!


Regards,
Christoph

This Email was scanned by Sophos Anti Virus