You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/12 15:05:30 UTC

[GitHub] [incubator-iotdb] yuqi1129 opened a new pull request #1728: [IOTDB-892] Replace fastjson with Gson

yuqi1129 opened a new pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-698395609


   @qiaojialin , OK, i have updated the code,  can anyone help to review the code ？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 closed pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 closed pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691597506


   1. please notice the CI.
   2. can you introduce more about what benefit we can get from this replacement?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691921385


   Hi, please pay attention to the ci. The IoTDBMetadataFetchIT.databaseMetaDataTest failed. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691922671


   OK, i will do it after when i get off work today
   
   Jialin Qiao <no...@github.com> 于2020年9月14日周一 下午5:00写道：
   
   > Hi, please pay attention to the ci. The
   > IoTDBMetadataFetchIT.databaseMetaDataTest failed.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691921385>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADYQDBCATYAIYGW2V37IF63SFXLUHANCNFSM4RJTVRAA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 closed pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 closed pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-698395609


   @qiaojialin , OK, i have updated the code,  can anyone help to review the code ？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin removed a comment on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
qiaojialin removed a comment on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691921385


   Hi, please pay attention to the ci. The IoTDBMetadataFetchIT.databaseMetaDataTest failed. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1728:
URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691600279


   @jixuan1989 OK


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org