You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dan Zehme (JIRA)" <my...@incubator.apache.org> on 2005/07/21 15:40:50 UTC

[jira] Created: (MYFACES-346) ExtensionFilter does not close output streams before retrieving response bytes

ExtensionFilter does not close output streams before retrieving response bytes
------------------------------------------------------------------------------

         Key: MYFACES-346
         URL: http://issues.apache.org/jira/browse/MYFACES-346
     Project: MyFaces
        Type: Bug
    Versions: 1.0.9 beta    
 Environment: Windows 2000 Server, JBoss 3.2.2
    Reporter: Dan Zehme


For small pages, the ExtensionFilter can cause the page to be retruned with no data.

This happens because the output streams created by the ExtensionsResponseWrapper are not closed before the bytes of the response are accessed.

In ExtensionsFilter.doFilter, after the chain.doFilter(...), the following line needs to be inserted:

extendedResponse.finishResponse();

This closes the output streams and flushes all of the bytes.  It looks like finishResponse() was previously created for this purpose, but it is unreferrenced.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (MYFACES-346) ExtensionFilter does not close output streams before retrieving response bytes

Posted by "Bruno Aranda (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-346?page=all ]
     
Bruno Aranda closed MYFACES-346:
--------------------------------

    Fix Version: Nightly Build
     Resolution: Fixed

This should be solved in the next nightly build. Thanks for reporting!

> ExtensionFilter does not close output streams before retrieving response bytes
> ------------------------------------------------------------------------------
>
>          Key: MYFACES-346
>          URL: http://issues.apache.org/jira/browse/MYFACES-346
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: Windows 2000 Server, JBoss 3.2.2
>     Reporter: Dan Zehme
>      Fix For: Nightly Build

>
> For small pages, the ExtensionFilter can cause the page to be retruned with no data.
> This happens because the output streams created by the ExtensionsResponseWrapper are not closed before the bytes of the response are accessed.
> In ExtensionsFilter.doFilter, after the chain.doFilter(...), the following line needs to be inserted:
> extendedResponse.finishResponse();
> This closes the output streams and flushes all of the bytes.  It looks like finishResponse() was previously created for this purpose, but it is unreferrenced.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira