You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Milan Cermak <mi...@gmail.com> on 2020/09/22 13:40:28 UTC
Intro and ticket BEAM-10938
Hi,
I'm Milan, I'm a software engineer and I'm new to Beam.
I've noticed this new issue in JIRA (
https://issues.apache.org/jira/browse/BEAM-10938). Out of curiosity, I
decided to dig deeper and see if I can add the functionality. I think I got
it (you can see the diff here
https://github.com/apache/beam/compare/master...milancermak:BEAM-10938),
but then I've also noticed the status is "Triage needed" which, I assume,
means it's not yet decided by the community if this should be worked on at
all. Is that right? Should I send a PR or wait until the status clears? Any
guidance is appreciated.
FWIW, my JIRA username is milancermak
Cheers,
Milan
Re: Intro and ticket BEAM-10938
Posted by Milan Cermak <mi...@gmail.com>.
Thank you for the input. I've just opened a PR for the ticket 🤞
On 2020/09/22 17:08:06, Kenneth Knowles <ke...@apache.org> wrote:
> The way I use "Triage Needed" is to make sure there is some queue of
> incoming bugs that can be looked at. The level where I click "triaged" is
> when:
>
> - priority is right (https://beam.apache.org/contribute/jira-priorities/)
> - components are right
> - any needed tags
> - bug type is right
> - sometimes tag somebody who might know something about it
>
> It doesn't mean there is any decision about anything else. The assumption
> is that most users and new contributors will just not know about these
> things so it is good to check and help make sure the ticket gets attention.
> If you are filing the ticket for yourself to implement, then I am sure it
> is getting attention :-)
>
> Kenn
>
> On Tue, Sep 22, 2020 at 9:45 AM Luke Cwik <lc...@google.com> wrote:
>
> > Thanks for reaching out.
> >
> > "Triage needed" is the default state when a bug is opened and does not
> > mean that it is yet to be decided. Typically if there is something of note,
> > either the contributor asks on the dev@ mailing list about it and works
> > with the community or opens a PR and a reviewer will bring the PR to
> > discussion within the community. The former happens for "larger" things and
> > the "latter" is typically for smaller things when some kind of ambiguity in
> > a decision.
> >
> > I have added you as a contributor to the Beam JIRA project and assigned
> > BEAM-10938 to you. Feel free to open the PR and find a committer to review
> > it (ask the issue creator or a committer who is familiar with the code in
> > the location (via git blame) for a review and tag them with R: @nickname).
> >
> >
> > On Tue, Sep 22, 2020 at 9:37 AM Milan Cermak <mi...@gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I'm Milan, I'm a software engineer and I'm new to Beam.
> >>
> >> I've noticed this new issue in JIRA (
> >> https://issues.apache.org/jira/browse/BEAM-10938). Out of curiosity, I
> >> decided to dig deeper and see if I can add the functionality. I think I got
> >> it (you can see the diff here
> >> https://github.com/apache/beam/compare/master...milancermak:BEAM-10938),
> >> but then I've also noticed the status is "Triage needed" which, I assume,
> >> means it's not yet decided by the community if this should be worked on at
> >> all. Is that right? Should I send a PR or wait until the status clears? Any
> >> guidance is appreciated.
> >>
> >> FWIW, my JIRA username is milancermak
> >>
> >> Cheers,
> >>
> >> Milan
> >>
> >
>
Re: Intro and ticket BEAM-10938
Posted by Kenneth Knowles <ke...@apache.org>.
The way I use "Triage Needed" is to make sure there is some queue of
incoming bugs that can be looked at. The level where I click "triaged" is
when:
- priority is right (https://beam.apache.org/contribute/jira-priorities/)
- components are right
- any needed tags
- bug type is right
- sometimes tag somebody who might know something about it
It doesn't mean there is any decision about anything else. The assumption
is that most users and new contributors will just not know about these
things so it is good to check and help make sure the ticket gets attention.
If you are filing the ticket for yourself to implement, then I am sure it
is getting attention :-)
Kenn
On Tue, Sep 22, 2020 at 9:45 AM Luke Cwik <lc...@google.com> wrote:
> Thanks for reaching out.
>
> "Triage needed" is the default state when a bug is opened and does not
> mean that it is yet to be decided. Typically if there is something of note,
> either the contributor asks on the dev@ mailing list about it and works
> with the community or opens a PR and a reviewer will bring the PR to
> discussion within the community. The former happens for "larger" things and
> the "latter" is typically for smaller things when some kind of ambiguity in
> a decision.
>
> I have added you as a contributor to the Beam JIRA project and assigned
> BEAM-10938 to you. Feel free to open the PR and find a committer to review
> it (ask the issue creator or a committer who is familiar with the code in
> the location (via git blame) for a review and tag them with R: @nickname).
>
>
> On Tue, Sep 22, 2020 at 9:37 AM Milan Cermak <mi...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I'm Milan, I'm a software engineer and I'm new to Beam.
>>
>> I've noticed this new issue in JIRA (
>> https://issues.apache.org/jira/browse/BEAM-10938). Out of curiosity, I
>> decided to dig deeper and see if I can add the functionality. I think I got
>> it (you can see the diff here
>> https://github.com/apache/beam/compare/master...milancermak:BEAM-10938),
>> but then I've also noticed the status is "Triage needed" which, I assume,
>> means it's not yet decided by the community if this should be worked on at
>> all. Is that right? Should I send a PR or wait until the status clears? Any
>> guidance is appreciated.
>>
>> FWIW, my JIRA username is milancermak
>>
>> Cheers,
>>
>> Milan
>>
>
Re: Intro and ticket BEAM-10938
Posted by Luke Cwik <lc...@google.com>.
Thanks for reaching out.
"Triage needed" is the default state when a bug is opened and does not mean
that it is yet to be decided. Typically if there is something of note,
either the contributor asks on the dev@ mailing list about it and works
with the community or opens a PR and a reviewer will bring the PR to
discussion within the community. The former happens for "larger" things and
the "latter" is typically for smaller things when some kind of ambiguity in
a decision.
I have added you as a contributor to the Beam JIRA project and assigned
BEAM-10938 to you. Feel free to open the PR and find a committer to review
it (ask the issue creator or a committer who is familiar with the code in
the location (via git blame) for a review and tag them with R: @nickname).
On Tue, Sep 22, 2020 at 9:37 AM Milan Cermak <mi...@gmail.com> wrote:
> Hi,
>
> I'm Milan, I'm a software engineer and I'm new to Beam.
>
> I've noticed this new issue in JIRA (
> https://issues.apache.org/jira/browse/BEAM-10938). Out of curiosity, I
> decided to dig deeper and see if I can add the functionality. I think I got
> it (you can see the diff here
> https://github.com/apache/beam/compare/master...milancermak:BEAM-10938),
> but then I've also noticed the status is "Triage needed" which, I assume,
> means it's not yet decided by the community if this should be worked on at
> all. Is that right? Should I send a PR or wait until the status clears? Any
> guidance is appreciated.
>
> FWIW, my JIRA username is milancermak
>
> Cheers,
>
> Milan
>