You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/05/13 14:04:12 UTC
[jira] [Commented] (SOLR-9085) DateRangeField is broken before the
year 1582
[ https://issues.apache.org/jira/browse/SOLR-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282712#comment-15282712 ]
ASF subversion and git services commented on SOLR-9085:
-------------------------------------------------------
Commit 4193e60b9fc1ff12df2267778213ae3b0f04fb84 in lucene-solr's branch refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4193e60 ]
SOLR-9080 SOLR-9085: Fix date math before the year 1582.
note: DateMathParser no longer needs a Locale
> DateRangeField is broken before the year 1582
> ---------------------------------------------
>
> Key: SOLR-9085
> URL: https://issues.apache.org/jira/browse/SOLR-9085
> Project: Solr
> Issue Type: Bug
> Affects Versions: 6.0
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 6.1
>
> Attachments: SOLR-9085.patch
>
>
> DateRangeField has some issues for dates before 1582 (the Gregorian Change Date), following Solr 6. The main problem is that it uses DateMathParser which no longer observes a GCD and then it converts that Date to a Calendar using Calendar.setTime(date) which considers the GCD. We can't altogether avoid Calendar.java as in SOLR-9080 because DateRangePrefixTree currently fundamentally depends on it. However I recently learned we can simply change the GCD like so: {{cal.setGregorianChange(new Date(Long.MIN_VALUE));}} beforehand. DateRangeField also calls Calendar.getTime as well, which is affected by GCD considerations.
> For users that use DateRangeField but do *not* use "Date Math" and do not have 'Z' in their date strings then date strings are completely parsed by DateRangePrefixTree and there should be no issue.
> DateRangePrefixTree ought to be improved a bit too (in a separate issue)... like making the GCD configurable, and setting using SimpleDateFormatter.setCalendar it uses to format.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org