You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/07/27 14:14:46 UTC

Review Request 68082: Clarified instructions in docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

The instructions for using libprocess memory profiling
together with a custom libjemalloc.so had accidentally
omitted a required condition.


Diffs
-----

  docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 


Diff: https://reviews.apache.org/r/68082/diff/1/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 68082: Clarified instructions in docs.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/#review206544
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On July 27, 2018, 2:14 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68082/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 2:14 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for using libprocess memory profiling
> together with a custom libjemalloc.so had accidentally
> omitted a required condition.
> 
> 
> Diffs
> -----
> 
>   docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 
> 
> 
> Diff: https://reviews.apache.org/r/68082/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 68082: Clarified instructions in docs.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/#review206545
-----------------------------------------------------------



PASS: Mesos patch 68082 was successfully built and tested.

Reviews applied: `['68082']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1990/mesos-review-68082

- Mesos Reviewbot Windows


On July 27, 2018, 2:14 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68082/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 2:14 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for using libprocess memory profiling
> together with a custom libjemalloc.so had accidentally
> omitted a required condition.
> 
> 
> Diffs
> -----
> 
>   docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 
> 
> 
> Diff: https://reviews.apache.org/r/68082/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>