You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/08/23 16:32:24 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request, #5219: Onboard Camel K Runtime fixups

ppalaga opened a new pull request, #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219

   Some enhancements on top of https://github.com/apache/camel-quarkus/pull/5117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1695318383

   So there seems to exist an agreement that this PR should aim 3.3.0.
   Hence I am going to rebase this after we release 3.2.0. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690289009

   > I was thinking the reverse 🙂. We are effectively done with 3.2.0, not sure I like introducing a change like this at this stage. Safer to defer for 3.3.0 IMO.
   
   I won't stand in a way then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #5219: Onboard Camel K Runtime fixups

Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#discussion_r1308791827


##########
integration-tests/camel-k-runtime/src/main/resources/application.properties:
##########
@@ -0,0 +1,22 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements.  See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License.  You may obtain a copy of the License at
+##
+##      http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus
+#
+#quarkus.log.console.enable = false

Review Comment:
   We may drop that commented line



##########
integration-tests/camel-k-runtime/src/test/java/org/apache/camel/quarkus/k/it/RuntimeCustomizerFallbackTest.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.k.it;
+
+import java.util.Map;
+
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.restassured.path.json.JsonPath;
+import jakarta.ws.rs.core.MediaType;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import static io.restassured.RestAssured.given;
+import static org.apache.camel.util.CollectionHelper.mapOf;
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Disabled
+//@TestProfile(RuntimeCustomizerFallbackTest.Profile.class)
+//@QuarkusTest

Review Comment:
   Is this one missing, or Do we want to keep it Disabled ?



##########
integration-tests/camel-k-runtime/src/test/java/org/apache/camel/quarkus/k/it/RuntimeCustomizerTest.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.k.it;
+
+import java.util.Map;
+
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.restassured.path.json.JsonPath;
+import jakarta.ws.rs.core.MediaType;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import static io.restassured.RestAssured.given;
+import static org.apache.camel.util.CollectionHelper.mapOf;
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Disabled
+//@TestProfile(RuntimeCustomizerTest.Profile.class)
+//@QuarkusTest

Review Comment:
   Same question here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zhfeng commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1691214669

   It looks like `camel-k-runtime` tests are failing on windows build due to lack of Docker environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zhfeng commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1691221420

   @zbendhiba For releasing `3.3.0`, please make sure we have all changes in
   - https://github.com/apache/camel-quarkus/pull/5190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1698814137

   5c4c745:
   
   * Rebased
   * Addressed the feedback from @zbendhiba 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1691285572

   With Camel-K 2.0, we should already have less coupling between Camel Quarkus and Camel-K ? So that should be ok to merge this pr in next 3.3.0 release ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690283989

   > Are we proposing to merge this for 3.2.0?
   
   That's a good question. I think it would be very practical to have this in the LTS. Any opinion, @claudio4j?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690281501

   Are we proposing to merge this for 3.2.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1693349299

   866fe21: 
   
   * Rebased
   * Squashed all commits
   * Added `skip-testcontainers-tests` profile to the new Camel K test module
   
   ```
           <profile>
               <id>skip-testcontainers-tests</id>
               <activation>
                   <property>
                       <name>skip-testcontainers-tests</name>
                   </property>
               </activation>
               <properties>
                   <skipTests>true</skipTests>
               </properties>
           </profile>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zhfeng commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690850021

   I'm also not confident to introduce such a big change in last minute before releasing `3.2.0`. I think @zbendhiba is preparing for the new release this week. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1691318115

   > It looks like camel-k-runtime tests are failing on windows build due to lack of Docker environment.
   
   Thanks for having a look @zhfeng! I am away for a RH event today and I'll be able to address this only tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690287068

   > I think it would be very practical to have this in the LTS
   
   I was thinking the reverse :slightly_smiling_face:. We are effectively done with 3.2.0, not sure I like introducing a change like this at this stage. Safer to defer for 3.3.0 IMO.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1691185430

   I was thinking of releasing 3.3.0 very soon after 3.2.0, so that we go back to the release cadence we used to have before. The 2 versions will be based on Camel 4, but 3.2.0 is an LTS. 
   I also think it makes sense to have the experimental stuff for 3.3.0 and Camel k team will have quickly 3.3.0 to start experimenting stuff. is that makes sense for you @claudio4j  ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] claudio4j commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1693560479

   > I was thinking of releasing 3.3.0 very soon after 3.2.0, so that we go back to the release cadence we used to have before. The 2 versions will be based on Camel 4, but 3.2.0 is an LTS. I also think it makes sense to have the experimental stuff for 3.3.0 and Camel k team will have quickly 3.3.0 to start experimenting stuff. is that makes sense for you @claudio4j ?
   
   Sounds good to me, thanks for the feedback everyone.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] claudio4j commented on pull request #5219: Onboard Camel K Runtime fixups

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#issuecomment-1690506462

   Thanks Peter.
   @jamesnetherton  This onboard to a camel-quarkus release will give us a important opportunity to decrease dependency of camel-k-runtime. Also, given that camel-k-runtime extension should not be visible or usable for regular camel-quarkus, I would say this onboard has very minimal risk to disrupt anything in camel-quarkus applications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#discussion_r1309962717


##########
integration-tests/camel-k-runtime/src/main/resources/application.properties:
##########
@@ -0,0 +1,22 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements.  See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License.  You may obtain a copy of the License at
+##
+##      http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus
+#
+#quarkus.log.console.enable = false

Review Comment:
   Solved in 5c4c745



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5219: Onboard Camel K Runtime fixups

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5219:
URL: https://github.com/apache/camel-quarkus/pull/5219#discussion_r1309971179


##########
integration-tests/camel-k-runtime/src/test/java/org/apache/camel/quarkus/k/it/RuntimeCustomizerFallbackTest.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.k.it;
+
+import java.util.Map;
+
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.restassured.path.json.JsonPath;
+import jakarta.ws.rs.core.MediaType;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import static io.restassured.RestAssured.given;
+import static org.apache.camel.util.CollectionHelper.mapOf;
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Disabled
+//@TestProfile(RuntimeCustomizerFallbackTest.Profile.class)
+//@QuarkusTest

Review Comment:
   Thanks for noticing, @zbendhiba, I created a followup https://github.com/apache/camel-quarkus/issues/5235 for this and added `@Disabled("https://github.com/apache/camel-quarkus/issues/5235")` to the failing test.



##########
integration-tests/camel-k-runtime/src/test/java/org/apache/camel/quarkus/k/it/RuntimeCustomizerTest.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.k.it;
+
+import java.util.Map;
+
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.restassured.path.json.JsonPath;
+import jakarta.ws.rs.core.MediaType;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import static io.restassured.RestAssured.given;
+import static org.apache.camel.util.CollectionHelper.mapOf;
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Disabled
+//@TestProfile(RuntimeCustomizerTest.Profile.class)
+//@QuarkusTest

Review Comment:
   Thanks for noticing, @zbendhiba, I created a followup https://github.com/apache/camel-quarkus/issues/5235 for this and added `@Disabled("https://github.com/apache/camel-quarkus/issues/5235")` to the failing test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org