You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/01 03:55:41 UTC
[GitHub] [incubator-seatunnel] Hisoka-X opened a new pull request, #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Hisoka-X opened a new pull request, #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Add code from LogicalDag to PhysicalPlan
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316#issuecomment-1202309423
> I don't found the `TaskGroup` in this pr. It is different from the design.
I will fix this in next PR, with jar url together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316#issuecomment-1200837468
I see you use `Vertex` in PhysicalPlan. I don't think the vertices of logical plan and physical plan are the same. In physical plan physical vertices need to express y a vertex that can be executed or further converted into a task. If the value of the parallelism attribute of a logical vertex is 4, there should be at least 4 physical vertices in the corresponding physical plan, and each physical vertex should contain an index attribute to express the index of the physical vertex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316#issuecomment-1203693985
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316#discussion_r934202949
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/dag/actions/UnknownActionException.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.engine.core.dag.actions;
+
+public class UnknownActionException extends RuntimeException {
Review Comment:
I suggest putting the `UnknowActionException` in `seatunnel-engine-common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2316: [Engine][PhysicalPlan] Add code from LogicalDag to PhysicalPlan
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2316:
URL: https://github.com/apache/incubator-seatunnel/pull/2316#issuecomment-1200847842
> I see you use `Vertex` in PhysicalPlan. I don't think the vertices of logical plan and physical plan are the same. In physical plan physical vertices need to express y a vertex that can be executed or further converted into a task. If the value of the parallelism attribute of a logical vertex is 4, there should be at least 4 physical vertices in the corresponding physical plan, and each physical vertex should contain an index attribute to express the index of the physical vertex.
Hi, `Vertex` already be converted to task list with `ActionWrapper` in the physical plan. There no Vertex in the physical plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org