[GitHub] [geode] boglesby commented on issue #3027: GEODE-6205: Set disk-dir in gfsh either absolute or relative based on…

["boglesby (GitHub)" <gi...@apache.org>]

@Petahhh: Yes, thats right. This is changing what is persisted in cluster configuration. Without the change, this command:
```
create disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir
```
Saved the relative `disk-dir` to cluster configuration:
```
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
    <disk-dir>myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>
```
When a new server was started, it created a DiskStore in the working directory instead of the absolute directory.

With the change, this command:
```
create disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir
```
Saves the absolute `disk-dir` to cluster configuration:
```
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
    <disk-dir>/absolute/path/to/myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>
```
And this command:
```
create disk-store --name=DISKSTORE --dir=myDiskDir
```
Saves the relative `disk-dir` to cluster configuration:
```
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
      <disk-dir>myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>
```
In both cases, the server gets the correct disk directory.

Basically whatever is typed as the value of the `dir` in the command is saved to cluster configuration.


[ Full content available at: https://github.com/apache/geode/pull/3027 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org