[jira] [Commented] (BEAM-1578) Runners should put PT overrides into a list rather than map

["Daniel Halperin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949400#comment-15949400 ] 

Daniel Halperin commented on BEAM-1578:
---------------------------------------

[~tgroh] – any feedback here?

> Runners should put PT overrides into a list rather than map
> -----------------------------------------------------------
>
>                 Key: BEAM-1578
>                 URL: https://issues.apache.org/jira/browse/BEAM-1578
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, runner-direct
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>            Priority: Minor
>
> It was not clear to me from the code that order of overrides is important. Map is not the best data structure for this, especially since no key lookups happen.
> Referring to
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
> and
> https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java
> and possibly others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)