You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/12/12 19:21:35 UTC
[GitHub] [accumulo] dlmarion opened a new issue, #3120: ZK Users path missing in Constants
dlmarion opened a new issue, #3120:
URL: https://github.com/apache/accumulo/issues/3120
Create a ZUSERS path variable in Constants, use in ZKAuthenticator at https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthenticator.java#L56 and maybe other locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ddanielr commented on issue #3120: ZK Users path missing in Constants
Posted by GitBox <gi...@apache.org>.
ddanielr commented on issue #3120:
URL: https://github.com/apache/accumulo/issues/3120#issuecomment-1347179869
@dlmarion :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #3120: ZK Users path missing in Constants
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #3120:
URL: https://github.com/apache/accumulo/issues/3120#issuecomment-1351996540
The `/users` is specific to the ZKAuthenticator, and not, as a general rule, part of Accumulo at large, with other authenticators. That said, the authentication stuff probably needs work, and any work I can imagine would have a `/users` for at least the built-in local superuser ("root"), so it's probably okay to have this exist for all authenticators. Right now, though, only ZKAuthenticator and those that might be derived from it make use of this path, so it's still very specific to those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ddanielr commented on issue #3120: ZK Users path missing in Constants
Posted by GitBox <gi...@apache.org>.
ddanielr commented on issue #3120:
URL: https://github.com/apache/accumulo/issues/3120#issuecomment-1347201021
So is my understanding correct?
`ZKUserPath` is scoped correctly and does not need to be modified.
1. Define a `/users` var in Constants called `ZKUSERS` for use in all ZKuser paths:
https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/Constants.java
2. Find all instances of hardcoded `/users` path in use by any `ZKUser` operations and replace with new `ZKUSERS` Constant value.
Intended fix should look like `ZKUserPath = Constants.ZROOT + "/" + context.getInstanceID() + Constants.ZUSERS;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion closed issue #3120: ZK Users path missing in Constants
Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #3120: ZK Users path missing in Constants
URL: https://github.com/apache/accumulo/issues/3120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #3120: ZK Users path missing in Constants
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #3120:
URL: https://github.com/apache/accumulo/issues/3120#issuecomment-1347203972
Yes. Might be useful to look for any "/users" string in the code and evaluate whether it should use the new constant. There may be some tests.
> replace with new ZKUSERS Constant value
I think should be `ZUSERS` based on convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org