You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/04/26 08:13:39 UTC

s/::/__/g for mp2 tests

I think there's a change needed for consistency in the recent 
shift from :: to __ in the <Location> directives in the 
mod_perl 2 tests:

======================================================
Index: lookup_uri2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPI/lookup_uri2.pm,v
retrieving revision 1.2
diff -u -r1.2 lookup_uri2.pm
--- lookup_uri2.pm	11 Apr 2002 11:08:43 -0000	1.2
+++ lookup_uri2.pm	26 Apr 2003 06:18:02 -0000
@@ -26,7 +26,8 @@
 
 sub subrequest {
     my($r, $sub) = @_;
-    $r->lookup_uri(join '::', __PACKAGE__, $sub)->run;
+    (my $uri = join '::', __PACKAGE__, $sub) =~ s!::!__!g;
+    $r->lookup_uri($uri)->run;
 }
 
 sub handler {
@@ -43,12 +44,12 @@
 
 1;
 __DATA__
-<Location /TestAPI::lookup_uri2::myplan>
+<Location /TestAPI__lookup_uri2__myplan>
     SetHandler modperl
     PerlResponseHandler TestAPI::lookup_uri2::myplan
 </Location>
 
-<Location /TestAPI::lookup_uri2::ok3>
+<Location /TestAPI__lookup_uri2__ok3>
     SetHandler modperl
     PerlResponseHandler TestAPI::lookup_uri2::ok3
 </Location>
======================================================== 
Without this, I was getting an "illegal division by 0"
error from the most recent Test-Harness package.

-- 
best regards,
randy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: s/::/__/g for mp2 tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> I think there's a change needed for consistency in the recent 
> shift from :: to __ in the <Location> directives in the 
> mod_perl 2 tests:
[...]
> ======================================================== 
> Without this, I was getting an "illegal division by 0"
> error from the most recent Test-Harness package.

+1, please commit

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org