You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/16 07:33:21 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #4556: xtensa:backtrace: flush to stack when in interrupt
zhuyanlinzyl opened a new pull request #4556:
URL: https://github.com/apache/incubator-nuttx/pull/4556
The registers may be in window when in interrupt.
Flush window stack to stack first.
And fix warning in build.
Change-Id: I45f3a8e6aa4f8baa1d54871a02bd6defc8915144
## Summary
## Impact
No
## Testing
Test with xtensa interrupt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4556: xtensa:backtrace: flush to stack when in interrupt
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4556:
URL: https://github.com/apache/incubator-nuttx/pull/4556#issuecomment-921024727
Let's ignore the false macOS CI failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4556: xtensa:backtrace: flush to stack when in interrupt
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4556:
URL: https://github.com/apache/incubator-nuttx/pull/4556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4556: xtensa:backtrace: flush to stack when in interrupt
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4556:
URL: https://github.com/apache/incubator-nuttx/pull/4556#discussion_r709899110
##########
File path: arch/xtensa/src/common/xtensa_backtrace.c
##########
@@ -219,6 +225,8 @@ int up_backtrace(FAR struct tcb_s *tcb, FAR void **buffer, int size)
{
if (up_interrupt_context())
{
+ xtensa_window_spill();
Review comment:
move after line 236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org