You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/06 22:00:55 UTC

[GitHub] [incubator-druid] jihoonson opened a new pull request #7203: Fix race in historical when loading segments in parallel

jihoonson opened a new pull request #7203: Fix race in historical when loading segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7203
 
 
   Partially addresses https://github.com/apache/incubator-druid/issues/7192.
   
   In this PR, 
   
   - `segmentManager` is supposed to be thread-safe, but `segmentLoader` in it is not. Now, it's synchronized when it's accessed.
   - In `BatchDataSegmentAnnouncer.announceSegment()`, `if (segmentLookup.containsKey(segment))` is checked again inside of the lock.
   - In `HttpLoadQueuePeon`, `batchSize` counts only unexpired requests.
   - Added tests for `BatchDataSegmentAnnouncer` and `SegmentManager`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org