You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/03/14 12:47:44 UTC
[jira] [Commented] (TS-2630) Add lib/ts/apidefs.h to place common
types
[ https://issues.apache.org/jira/browse/TS-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934904#comment-13934904 ]
ASF subversion and git services commented on TS-2630:
-----------------------------------------------------
Commit 175dbca3718db208a24d1544fa468ca87cdfe0d2 in trafficserver's branch refs/heads/master from [~yunkai]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=175dbca ]
TS-2630: Add lib/ts/apidefs.h to place common types
The apidefs.h file is used to place common types that can be shared
between internal code and TS APIs.
It's hard to judge what types in api/ts/ts.h should be migrated to
lib/ts/apidefs.h, so this patch is just a beginning ...
Why I named it 'apidefs.h' instead of 'defs.h' and put it into 'lib/ts'?
1) Firstly, there is a 'ink_defs.h' file in 'lib/ts', then 'defs.h' seems
too similar with it. So named it 'apidefs.h' would be more clearly.
2) Since 'apidefs.h' will be shared not only by 'iocore' modules, puting it
into 'lib/ts' would be more suitable than 'iocore/api' or any other else.
Signed-off-by: Yunkai Zhang <qi...@taobao.com>
> Add lib/ts/apidefs.h to place common types
> ------------------------------------------
>
> Key: TS-2630
> URL: https://issues.apache.org/jira/browse/TS-2630
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, TS API
> Reporter: Yunkai Zhang
> Assignee: Yunkai Zhang
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2630-Add-lib-ts-apidefs.h-to-place-common-types.patch
>
>
> The apidefs.h file is used to place common types that can be shared
> between internal code and TS APIs.
> It's hard to judge what types in api/ts/ts.h should be migrated to
> lib/ts/apidefs.h, so this patch is just a beginning ...
> Why I named it 'apidefs.h' instead of 'defs.h' and put it into 'lib/ts'?
> 1) Firstly, there is a 'ink_defs.h' file in 'lib/ts', then 'defs.h' seems
> too similar with it. So named it 'apidefs.h' would be more clearly.
> 2) Since 'apidefs.h' will be shared not only by 'iocore' modules, puting it
> into 'lib/ts' would be more suitable than 'iocore/api' or any other else.
--
This message was sent by Atlassian JIRA
(v6.2#6252)