You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/11/09 12:53:14 UTC

Review Request 74198: (UI) Relationship Attribute Filter button keeps loading

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74198/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab and Prasad Pawar.


Bugs: ATLAS-4710
    https://issues.apache.org/jira/browse/ATLAS-4710


Repository: atlas


Description
-------

The Relationship Attribute Filter button is stuck on the loading icon loop and filters don't appear.
This is working on the Entity Attribute Filter button and via the API call, but not on the UI.


Diffs
-----

  dashboardv2/public/js/views/search/RelationSearchLayoutView.js 18d6b7694 


Diff: https://reviews.apache.org/r/74198/diff/1/


Testing
-------

The above mentioned issue was only getting reproduced for specific internal relationships, So the fix has been provided in the patch and manually tested for all the internal relationships and by creating custom relationships and its working fine.


Thanks,

Farhan Khan


Re: Review Request 74198: (UI) Relationship Attribute Filter button keeps loading

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74198/#review224859
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Nov. 9, 2022, 12:53 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74198/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2022, 12:53 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4710
>     https://issues.apache.org/jira/browse/ATLAS-4710
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The Relationship Attribute Filter button is stuck on the loading icon loop and filters don't appear.
> This is working on the Entity Attribute Filter button and via the API call, but not on the UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/RelationSearchLayoutView.js 18d6b7694 
> 
> 
> Diff: https://reviews.apache.org/r/74198/diff/1/
> 
> 
> Testing
> -------
> 
> The above mentioned issue was only getting reproduced for specific internal relationships, So the fix has been provided in the patch and manually tested for all the internal relationships and by creating custom relationships and its working fine.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 74198: ATLAS-4710 : (UI) Relationship Attribute Filter button keeps loading

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74198/#review224860
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Nov. 9, 2022, 1:10 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74198/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2022, 1:10 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4710
>     https://issues.apache.org/jira/browse/ATLAS-4710
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The Relationship Attribute Filter button is stuck on the loading icon loop and filters don't appear.
> This is working on the Entity Attribute Filter button and via the API call, but not on the UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/RelationSearchLayoutView.js 18d6b7694 
> 
> 
> Diff: https://reviews.apache.org/r/74198/diff/1/
> 
> 
> Testing
> -------
> 
> The above mentioned issue was only getting reproduced for specific internal relationships, So the fix has been provided in the patch and manually tested for all the internal relationships and by creating custom relationships and its working fine.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 74198: ATLAS-4710 : (UI) Relationship Attribute Filter button keeps loading

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74198/
-----------------------------------------------------------

(Updated Nov. 9, 2022, 1:10 p.m.)


Review request for atlas, Jayendra Parab and Prasad Pawar.


Summary (updated)
-----------------

ATLAS-4710 : (UI) Relationship Attribute Filter button keeps loading


Bugs: ATLAS-4710
    https://issues.apache.org/jira/browse/ATLAS-4710


Repository: atlas


Description
-------

The Relationship Attribute Filter button is stuck on the loading icon loop and filters don't appear.
This is working on the Entity Attribute Filter button and via the API call, but not on the UI.


Diffs
-----

  dashboardv2/public/js/views/search/RelationSearchLayoutView.js 18d6b7694 


Diff: https://reviews.apache.org/r/74198/diff/1/


Testing
-------

The above mentioned issue was only getting reproduced for specific internal relationships, So the fix has been provided in the patch and manually tested for all the internal relationships and by creating custom relationships and its working fine.


Thanks,

Farhan Khan