You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/12/23 09:57:15 UTC

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis

totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis
URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r360830937
 
 

 ##########
 File path: t/plugin/limit-count-redis.t
 ##########
 @@ -209,3 +209,95 @@ passed
 [404, 503, 404, 503, 503]
 --- no_error_log
 [error]
+
 
 Review comment:
   > the test cases are not cover redis password. For example, right or wrong password
   
   `right or wrong` redis password is based on modifing the redis service (maybe in travis ci script? I'm confused with this now). Which may make  other test failed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services