You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/27 05:32:26 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #10098: ARROW-11990: [C++][Compute] Handle errors consistently

cyb70289 commented on a change in pull request #10098:
URL: https://github.com/apache/arrow/pull/10098#discussion_r620877738



##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -751,8 +747,10 @@ struct ScalarUnaryNotNull {
 //
 // struct Op {
 //   template <typename OutValue, typename Arg0Value, typename Arg1Value>
-//   static OutValue Call(KernelContext* ctx, Arg0Value arg0, Arg1Value arg1) {
+//   static OutValue Call(KernelContext* ctx, Arg0Value arg0, Arg1Value arg1, Status* st)
+//   {
 //     // implementation
+//     // NOTE: "status" is only populated with errors, not Status::OK()

Review comment:
       Done. Also changed two other similar comments.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org