You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by PurelyApplied <gi...@git.apache.org> on 2017/04/10 23:03:13 UTC

[GitHub] geode pull request #446: GEODE-1274: Migration from PulseLogWriter to Log4j ...

GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/446

    GEODE-1274: Migration from PulseLogWriter to Log4j standard and removal of associated classes.

    * To avoid dependency on geode-core, the pulse loggers are instantiated directly from LogManager, rather than canonical LogService (which itself extends LogManager).
    
    * Significant reduction of logging level state checks, relying on Log4j handling.
    * Significant reduction of string concatenation, relying on Log4j2 string substitutions.
    * Reduction of logging using an exception e.getMessage, favoring instead passing the exception itself for the stacktrace.
    * Multiple identical exception blocks collapsed.
    
    precheckin green on Test/IntegrationTest/Legacy.  Previous runs green on Distributed, but current still running.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode bugfix/GEODE-1274

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #446
    
----
commit 49f5f9f57768eaf005364149c212c20404f6d197
Author: Patrick Rhomberg <pr...@pivotal.io>
Date:   2017-03-22T20:27:34Z

    GEODE-1274: Migration from PulseLogWriter to Log4j standard and removal of associated classes.
    
    To avoid dependency on geode-core, the pulse loggers are instantiated directly from LogManager, rather than canonical LogService (which itself extends LogManager).
    
    Significant reduction of logging level state checks, relying on Log4j handling.
    Significant reduction of string concatenation, relying on Log4j2 string substitutions.
    Reduction of logging using an exception e.getMessage, favoring instead passing the exception itself for the stacktrace.
    Multiple identical exception blocks collapsed.

commit dd14d6b0bdce628cc13b3237de5efa0dc18c5661
Author: Patrick Rhomberg <pr...@pivotal.io>
Date:   2017-04-10T21:10:52Z

    Corrected merge error regarding random ports.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #446: GEODE-1274: Migration from PulseLogWriter to Log4j ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/446


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---