[GitHub] [superset] rusackas commented on a diff in pull request #19311: fix(sql lab): add quotes when autocompleting table names with spaces in the editor

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19311:
URL: https://github.com/apache/superset/pull/19311#discussion_r849571541


##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx:
##########
@@ -221,11 +221,15 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
             this.props.queryEditor.schema,
           );
         }
+
+        let { caption } = data;
+        if (data.meta === 'table' && caption.includes(' ')) {

Review Comment:
   @codemaster08240328 any updates here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org