You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/23 13:09:21 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #19324: feat: introduce hashids permalink keys
codecov[bot] edited a comment on pull request #19324:
URL: https://github.com/apache/superset/pull/19324#issuecomment-1076350454
# [Codecov](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19324](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1257f2b) into [master](https://codecov.io/gh/apache/superset/commit/b7ecb14230383da679a3f61e38faa33cdb5014f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7ecb14) will **decrease** coverage by `0.00%`.
> The diff coverage is `98.54%`.
```diff
@@ Coverage Diff @@
## master #19324 +/- ##
==========================================
- Coverage 66.65% 66.64% -0.01%
==========================================
Files 1674 1675 +1
Lines 64603 64629 +26
Branches 6500 6500
==========================================
+ Hits 43058 43070 +12
- Misses 19862 19876 +14
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.71% <58.77%> (+0.03%)` | :arrow_up: |
| mysql | `81.67% <98.54%> (+0.02%)` | :arrow_up: |
| postgres | `?` | |
| presto | `52.55% <58.77%> (+0.03%)` | :arrow_up: |
| python | `82.09% <98.54%> (-0.03%)` | :arrow_down: |
| sqlite | `81.49% <98.54%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.66% <ø> (-0.06%)` | :arrow_down: |
| [superset/temporary\_cache/utils.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGVtcG9yYXJ5X2NhY2hlL3V0aWxzLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.98% <0.00%> (+0.10%)` | :arrow_up: |
| [...uperset/dashboards/filter\_state/commands/create.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvY3JlYXRlLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset/dashboards/filter\_state/commands/update.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvdXBkYXRlLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/permalink/api.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvYXBpLnB5) | `87.27% <100.00%> (-0.45%)` | :arrow_down: |
| [superset/dashboards/permalink/commands/base.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvYmFzZS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/permalink/commands/create.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvY3JlYXRlLnB5) | `92.59% <100.00%> (ø)` | |
| [superset/dashboards/permalink/commands/get.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvZ2V0LnB5) | `82.35% <100.00%> (ø)` | |
| [superset/explore/form\_data/commands/create.py](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhwbG9yZS9mb3JtX2RhdGEvY29tbWFuZHMvY3JlYXRlLnB5) | `95.00% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/19324/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b7ecb14...1257f2b](https://codecov.io/gh/apache/superset/pull/19324?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org