You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/13 16:51:33 UTC
[GitHub] [maven] hboutemy opened a new pull request #676: MNG 7413
hboutemy opened a new pull request #676:
URL: https://github.com/apache/maven/pull/676
https://issues.apache.org/jira/browse/MNG-7413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy edited a comment on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038714658
eventually, we'll wait for the 3.8.x branch to become 3.9.x: I'm not in a hurry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r805545786
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
+ repository, which adds uniqueVersion property to usual repositories for download.</description>
Review comment:
you mean drop the comma that splits the sentence in more readable parts (for a french reader)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038320746
Please note that Modello 2.0.0 requires Java 8 to buld Maven 3.8.5 now. We never discussed such a move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038714658
eventually, we'll wait for the 3.8.x branch to become 3.9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038712067
you mean Maven core is the only project that can build with Java 7
I did not remember
notice that this is a PR, it is not merged: it prove review is useful :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1063753483
Why so many commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1063765049
uh, PR is till to 3.8.x branch instead of 3.9.x: I'll not merge with GitHub but with Git directly...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy closed pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy closed pull request #676:
URL: https://github.com/apache/maven/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o edited a comment on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038794764
> you mean Maven core is the only project that can build with Java 7 (then won't be able to upgrade its parent POM)? I did not remember notice that this is a PR, it is not merged: it prove review is useful :)
We at least said that Maven 3.8.x remains on 7 which means that we run all build on 7 as well since ITs are on 7 as well. Having 8 at build time and 7 at runtime was never discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r823473030
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -642,11 +642,11 @@
</field>
</fields>
</class>
- <class>
+ <class xdoc.anchorName="profile_build">
<name>BuildBase</name>
<version>3.0.0+</version>
<superClass>PluginConfiguration</superClass>
- <description>Generic informations for a build.</description>
+ <description>Build configuration in a profile.</description>
Review comment:
Is this really only used in profiles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r805600245
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
+ repository, which adds uniqueVersion property to usual repositories for download.</description>
Review comment:
Yes, because there is a basic rule in English for comma: If in doubt, do without. One ref: https://www.grammarly.com/blog/comma-before-which/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy edited a comment on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038712067
you mean Maven core is the only project that can build with Java 7 (then won't be able to upgrade its parent POM)?
I did not remember
notice that this is a PR, it is not merged: it prove review is useful :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038320746
Please note that Modello 2.0.0 requires Java 8 to buld Maven 3.8.5 now. We never discussed such a move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r830588847
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -642,11 +642,11 @@
</field>
</fields>
</class>
- <class>
+ <class xdoc.anchorName="profile_build">
<name>BuildBase</name>
<version>3.0.0+</version>
<superClass>PluginConfiguration</superClass>
- <description>Generic informations for a build.</description>
+ <description>Build configuration in a profile.</description>
Review comment:
yes, this is what I discovered: the split between BuildBase and Build does not exist for some abstract reason to introduce class inheritance, but because BuildBase is used in profile, then define everything that can be overridden in profile and Build is the full main build element (with additional sourceDirectory, and so on)
I did not expect to discover that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1063744437
@michael-o any objection to merge to Maven 3.9 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1063773338
Which are the actual commits you want to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1079921708
merged in https://github.com/apache/maven/commit/88d29675ae2a0998d5be134c7941e8fd6aa706bd for 3.9.x and https://github.com/apache/maven/commit/e85ff889b333b82da20b988fbb42bdbfdb814545 for master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #676:
URL: https://github.com/apache/maven/pull/676#issuecomment-1038794764
> you mean Maven core is the only project that can build with Java 7 (then won't be able to upgrade its parent POM)? I did not remember notice that this is a PR, it is not merged: it prove review is useful :)
We at least said that Maven 3.8.x remains on 7 which means that we run all build on 7 as well since ITs are on 7 as well. Having 8 at build time and 7 at runtime was never discusses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r805387432
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
Review comment:
`repository`
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
+ repository, which adds uniqueVersion property to usual repositories for download.</description>
Review comment:
`repository which`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #676: MNG 7413
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #676:
URL: https://github.com/apache/maven/pull/676#discussion_r805387432
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
Review comment:
`repository`
##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -1937,12 +1937,12 @@
</fields>
</class>
- <class>
+ <class xdoc.anchorName="deployment_repository">
<name>DeploymentRepository</name>
<superClass>Repository</superClass>
<version>4.0.0+</version>
- <description>Repository contains the information needed for deploying to the remote
- repository.</description>
+ <description>Deployment Repository contains the information needed for deploying to the remote
+ repository, which adds uniqueVersion property to usual repositories for download.</description>
Review comment:
`repository which`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org