You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "bryanck (via GitHub)" <gi...@apache.org> on 2023/09/13 18:21:12 UTC

[GitHub] [iceberg] bryanck commented on a diff in pull request #8272: Core, Hive, Nessie: Use ResolvingFileIO as default instead of HadoopFileIO

bryanck commented on code in PR #8272:
URL: https://github.com/apache/iceberg/pull/8272#discussion_r1324902972


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -67,6 +67,7 @@ public class JdbcCatalog extends BaseMetastoreCatalog
   private static final String NAMESPACE_EXISTS_PROPERTY = "exists";
   private static final Logger LOG = LoggerFactory.getLogger(JdbcCatalog.class);
   private static final Joiner SLASH = Joiner.on("/");
+  private static final String DEFAULT_FILE_IO_IMPL = "org.apache.iceberg.io.ResolvingFileIO";

Review Comment:
   You could use the name from the class potentially, rather than a string literal, as `ResolvingFileIO` is in core.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org