You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/24 21:23:42 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14328: Update mock version

TheNeuralBit commented on a change in pull request #14328:
URL: https://github.com/apache/beam/pull/14328#discussion_r600882500



##########
File path: sdks/python/setup.py
##########
@@ -146,7 +146,7 @@ def get_version():
     'grpcio>=1.29.0,<2',
     'hdfs>=2.1.0,<3.0.0',
     'httplib2>=0.8,<0.18.0',
-    'mock>=1.0.1,<3.0.0',

Review comment:
       I think this should really be a test-only dependency, but it predates us separating those out. Would it also unblock you if we move this to `REQUIRED_TEST_PACKAGES` so it's not required by default?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org