You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/07 09:49:12 UTC
[GitHub] [commons-collections] dota17 opened a new pull request #138: Update
the package-info.java
dota17 opened a new pull request #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] dota17 commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
dota17 commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-599927146
LGFM. It's fixed by the commit: f00daff8c8474a76f489b51584cd687894961fd8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] coveralls commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-596069578
[](https://coveralls.io/builds/29195975)
Coverage remained the same at 89.951% when pulling **cde94d4017d1a161e3287b5295e2c28f2a3dd78c on dota17:updatePackage-info** into **9831773447456466ae93b07e59ea76c8cce31787 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
aherbert commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-599641398
I believe the recent changes in master make this PR obsolete. Please check the current master and close or rebase the PR with new modifications.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on a change in pull
request #138: Update the package-info.java
Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#discussion_r389244609
##########
File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/package-info.java
##########
@@ -16,7 +16,7 @@
*/
/**
- * Implementations of org.apache.commons.collections4.bloomfilter.Hasher
+ * Implementations of org.apache.commons.collections4.bloomfilter.hasher
Review comment:
As above this is just a skeleton
```
Provides implementations of the {@link org.apache.commons.collections4.bloomfilter.hasher.HashFunction}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] dota17 closed pull request #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
dota17 closed pull request #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on a change in pull
request #138: Update the package-info.java
Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#discussion_r389244501
##########
File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/package-info.java
##########
@@ -16,7 +16,7 @@
*/
/**
- * Implementations of org.apache.commons.collections4.bloomfilter.hasher.HasherFunction
+ * Implementations of org.apache.commons.collections4.bloomfilter.hasher.function
Review comment:
This package info is a skeleton. It should really be expanded. For now it could probably be changed to:
```
Provides classes and interfaces to define the shape of a Bloom filter and the conversion
of generic bytes to a hash of bit indexes to be used with a Bloom filter.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] coveralls edited a comment on issue #138:
Update the package-info.java
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-596069578
[](https://coveralls.io/builds/29302207)
Coverage remained the same at 89.951% when pulling **c93f861960cf3e9f7184c8e6fcf64d7558b022b3 on dota17:updatePackage-info** into **9831773447456466ae93b07e59ea76c8cce31787 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
aherbert commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-599922032
Thanks. I have fixed the check for the number of bits in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] coveralls edited a comment on issue #138:
Update the package-info.java
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-596069578
[](https://coveralls.io/builds/29295081)
Coverage remained the same at 89.951% when pulling **56f0f9fe3e88c3bf93517ca8e07e7dcd7fd3291a on dota17:updatePackage-info** into **9831773447456466ae93b07e59ea76c8cce31787 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] dota17 commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
dota17 commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-599857214
Hello,"Alex Herbert" ,
commons-collections\src\main\java\org\apache\commons\collections4\bloomfilter\hasher\Shape.java Line 253 and 256 maybe update to 8.
/**
* Check number of bits is above 8.
*
* @param numberOfBits the number of bits
* @return the number of bits
* @throws IllegalArgumentException if the number of bits is {@code < 1}
*/
private static int checkNumberOfBits(final int numberOfBits) {
if (numberOfBits < 1) {
throw new IllegalArgumentException("Number of bits must be greater than or equal to 8: " + numberOfBits);
}
return numberOfBits;
}
LGFM about package-info.java.
在 2020-03-17 00:47:27，"Alex Herbert" <no...@github.com> 写道：
I believe the recent changes in master make this PR obsolete. Please check the current master and close or rebase the PR with new modifications.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on issue #138: Update the
package-info.java
Posted by GitBox <gi...@apache.org>.
aherbert commented on issue #138: Update the package-info.java
URL: https://github.com/apache/commons-collections/pull/138#issuecomment-598202950
Hi @dota17 ,
It seems that you are working on fixing more than just the package info. I have another PR to push through some fixes for the Bloom filter code. Part of this is a big update to Shape as the documentation was limited and as you have noticed in parts incorrect.
I have added commit to PR #140 that should cover updating the package info, the BloomFilterIndexer and the Shape class. Have a look and see if you can see issues. I was waiting for @Claudenw to have a look before merging. It should address all your fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services