You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 15:04:50 UTC
[GitHub] [flink] twalthr commented on a change in pull request #8493:
[FLINK-12562][table] Improve code in ExpandColumnFunctionsRule
twalthr commented on a change in pull request #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule
URL: https://github.com/apache/flink/pull/8493#discussion_r286539834
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/expressions/rules/ExpandColumnFunctionsRule.java
##########
@@ -193,7 +190,7 @@ public ColumnsExpressionExpander(List<UnresolvedReferenceExpression> inputFieldR
@Override
protected List<UnresolvedReferenceExpression> defaultMethod(Expression expression) {
- throw new TableException(
+ throw new ValidationException(
String.format("The parameters of %s() or %s() only accept column name or column " +
Review comment:
One additional location that looks like inconsistent regarding exceptions. Is the `Preconditions.checkArgument`. Usually this method is for checking if we (the Flink developers) did everything correct how every this check is also validating user input, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services