You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/03/22 02:01:31 UTC
[GitHub] flink pull request #5744: [FLINK-8931] TASK_KILLING is not covered by match ...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5744
[FLINK-8931] TASK_KILLING is not covered by match in TaskMonitor#whenUnhandled
## What is the purpose of the change
*This pull request makes _TASK_KILLING_ covered by match in `TaskMonitor#whenUnhandled`*
## Brief change log
- *Added _TASK_KILLING_ in last case *
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5744
----
commit 98c754214a24ff1ee1fff31a2fdaff7dc2f0a427
Author: yanghua <ya...@...>
Date: 2018-03-22T01:58:08Z
[FLINK-8931] TASK_KILLING is not covered by match in TaskMonitor#whenUnhandled
----
---
[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5744
Thanks for the contribution @yanghua. I fear that the `TASK_KILLING` states have been left out deliberately. When a task is being killed, then you don't stop. Thus, the issue is actually a non issue. What we could do is to make the match exhaustive to add a `TASK_KILLING => noOp`.
---
[GitHub] flink pull request #5744: [FLINK-8931] TASK_KILLING is not covered by match ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5744
---
[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5744
cc @tillrohrmann
---
[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5744
hi @tillrohrmann you mean change to `stay()`? I have changed to this style. It seems that in scala FSM we could not do nothing, it should return task monitor's state.
---