You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 07:54:14 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39237: [SPARK-41717][CONNECT][DOCS][FOLLOW-UP] Add docstrings for _parameters_to_print, print and _repr_html_ at LogicalPlan
HyukjinKwon opened a new pull request, #39237:
URL: https://github.com/apache/spark/pull/39237
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/39223 that addresses https://github.com/apache/spark/pull/39223#discussion_r1057437411, that adds some docstring for the fixed methods.
### Why are the changes needed?
For better readability.
### Does this PR introduce _any_ user-facing change?
No, these aren't API. It adds some doc for developers.
### How was this patch tested?
Linter should verify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39237: [SPARK-41717][CONNECT][DOCS][FOLLOW-UP] Add docstrings for _parameters_to_print, print and _repr_html_ at LogicalPlan
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39237:
URL: https://github.com/apache/spark/pull/39237#issuecomment-1365774352
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39237: [SPARK-41717][CONNECT][DOCS][FOLLOW-UP] Add docstrings for _parameters_to_print, print and _repr_html_ at LogicalPlan
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39237:
URL: https://github.com/apache/spark/pull/39237#issuecomment-1365688560
cc @grundprinzip and @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39237: [SPARK-41717][CONNECT][DOCS][FOLLOW-UP] Add docstrings for _parameters_to_print, print and _repr_html_ at LogicalPlan
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39237: [SPARK-41717][CONNECT][DOCS][FOLLOW-UP] Add docstrings for _parameters_to_print, print and _repr_html_ at LogicalPlan
URL: https://github.com/apache/spark/pull/39237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org