You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/04/14 19:31:48 UTC
[commons-lang] branch master updated: fix: swap the order of assertion args (first excepted then actual) (#1054)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new dd49aa9d1 fix: swap the order of assertion args (first excepted then actual) (#1054)
dd49aa9d1 is described below
commit dd49aa9d1f2cb8dca8f5bb19375f645e9ae04a3c
Author: 徐梦旗 <26...@qq.com>
AuthorDate: Sat Apr 15 03:31:39 2023 +0800
fix: swap the order of assertion args (first excepted then actual) (#1054)
---
.../org/apache/commons/lang3/ArrayUtilsTest.java | 30 +++++++++++-----------
.../exception/AbstractExceptionContextTest.java | 4 +--
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index 4f751c56d..7f496cd3f 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -2415,9 +2415,9 @@ public class ArrayUtilsTest extends AbstractLangTest {
public void testReverseByte() {
byte[] array = {2, 3, 4};
ArrayUtils.reverse(array);
- assertEquals(array[0], 4);
- assertEquals(array[1], 3);
- assertEquals(array[2], 2);
+ assertEquals(4, array[0]);
+ assertEquals(3, array[1]);
+ assertEquals(2, array[2]);
array = null;
ArrayUtils.reverse(array);
@@ -2460,9 +2460,9 @@ public class ArrayUtilsTest extends AbstractLangTest {
public void testReverseChar() {
char[] array = {'a', 'f', 'C'};
ArrayUtils.reverse(array);
- assertEquals(array[0], 'C');
- assertEquals(array[1], 'f');
- assertEquals(array[2], 'a');
+ assertEquals('C', array[0]);
+ assertEquals('f', array[1]);
+ assertEquals('a', array[2]);
array = null;
ArrayUtils.reverse(array);
@@ -2595,9 +2595,9 @@ public class ArrayUtilsTest extends AbstractLangTest {
public void testReverseInt() {
int[] array = {1, 2, 3};
ArrayUtils.reverse(array);
- assertEquals(array[0], 3);
- assertEquals(array[1], 2);
- assertEquals(array[2], 1);
+ assertEquals(3, array[0]);
+ assertEquals(2, array[1]);
+ assertEquals(1, array[2]);
array = null;
ArrayUtils.reverse(array);
@@ -2640,9 +2640,9 @@ public class ArrayUtilsTest extends AbstractLangTest {
public void testReverseLong() {
long[] array = {1L, 2L, 3L};
ArrayUtils.reverse(array);
- assertEquals(array[0], 3L);
- assertEquals(array[1], 2L);
- assertEquals(array[2], 1L);
+ assertEquals(3L, array[0]);
+ assertEquals(2L, array[1]);
+ assertEquals(1L, array[2]);
array = null;
ArrayUtils.reverse(array);
@@ -2717,9 +2717,9 @@ public class ArrayUtilsTest extends AbstractLangTest {
public void testReverseShort() {
short[] array = {1, 2, 3};
ArrayUtils.reverse(array);
- assertEquals(array[0], 3);
- assertEquals(array[1], 2);
- assertEquals(array[2], 1);
+ assertEquals(3, array[0]);
+ assertEquals(2, array[1]);
+ assertEquals(1, array[2]);
array = null;
ArrayUtils.reverse(array);
diff --git a/src/test/java/org/apache/commons/lang3/exception/AbstractExceptionContextTest.java b/src/test/java/org/apache/commons/lang3/exception/AbstractExceptionContextTest.java
index 3fbe50da5..035747389 100644
--- a/src/test/java/org/apache/commons/lang3/exception/AbstractExceptionContextTest.java
+++ b/src/test/java/org/apache/commons/lang3/exception/AbstractExceptionContextTest.java
@@ -140,8 +140,8 @@ public abstract class AbstractExceptionContextTest<T extends ExceptionContext &
public void testGetContextValues() {
exceptionContext.addContextValue("test2", "different value");
- assertEquals(exceptionContext.getContextValues("test1"), Collections.singletonList(null));
- assertEquals(exceptionContext.getContextValues("test2"), Arrays.asList("some value", "different value"));
+ assertEquals(Collections.singletonList(null), exceptionContext.getContextValues("test1"));
+ assertEquals(Arrays.asList("some value", "different value"), exceptionContext.getContextValues("test2"));
exceptionContext.setContextValue("test2", "another");