You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/01 15:09:04 UTC

[GitHub] [ignite] alex-plekhanov opened a new pull request, #10358: IGNITE-17984 SQL Calcite: Memory quotas

alex-plekhanov opened a new pull request, #10358:
URL: https://github.com/apache/ignite/pull/10358

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] asfgit closed pull request #10358: IGNITE-17984 SQL Calcite: Memory quotas

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #10358: IGNITE-17984 SQL Calcite: Memory quotas
URL: https://github.com/apache/ignite/pull/10358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ivandasch commented on a diff in pull request #10358: IGNITE-17984 SQL Calcite: Memory quotas

Posted by GitBox <gi...@apache.org>.
ivandasch commented on code in PR #10358:
URL: https://github.com/apache/ignite/pull/10358#discussion_r1028125834


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MemoryTrackingNode.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.processors.query.calcite.exec.tracker.ObjectSizeCalculator;
+import org.apache.ignite.internal.processors.query.calcite.exec.tracker.RowTracker;
+
+/**
+ * Abstract memory tracking node.
+ */
+public abstract class MemoryTrackingNode<Row> extends AbstractNode<Row> {
+    /** Estimated overhead of row in hash map (assuming key and value is an objects composed from the original row fields). */
+    protected static final long HASH_MAP_ROW_OVERHEAD = ObjectSizeCalculator.OBJ_REF_SIZE * 4 / 3 /* load factor */ +
+        ObjectSizeCalculator.HASH_MAP_ENTRY_SIZE;
+
+    /** Estimated overhead of row in array (assuming overhead is only size of extra reference to the row). */
+    protected static final long ARRAY_ROW_OVERHEAD = ObjectSizeCalculator.OBJ_REF_SIZE;
+
+    /** Default row overhead (assuming rows are stored in arrays by default). */
+    protected static final long DFLT_ROW_OVERHEAD = ARRAY_ROW_OVERHEAD;
+
+    /** Memory tracker for the current execution node. */
+    protected final RowTracker<Row> nodeMemoryTracker;
+
+    /**
+     * @param ctx Execution context.
+     * @param rowType Row type.
+     * @param rowOverhead Row overhead in bytes for each row.
+     */
+    protected MemoryTrackingNode(ExecutionContext<Row> ctx, RelDataType rowType, long rowOverhead) {
+        super(ctx, rowType);
+
+        nodeMemoryTracker = ctx.createNodeMemoryTracker(rowOverhead);
+    }
+
+    /** */
+    protected MemoryTrackingNode(ExecutionContext<Row> ctx, RelDataType rowType) {
+        this(ctx, rowType, DFLT_ROW_OVERHEAD);
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void closeInternal() {
+        nodeMemoryTracker.reset();;

Review Comment:
   Extra unneeded comma



##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MemoryTrackingNode.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.processors.query.calcite.exec.tracker.ObjectSizeCalculator;
+import org.apache.ignite.internal.processors.query.calcite.exec.tracker.RowTracker;
+
+/**
+ * Abstract memory tracking node.
+ */
+public abstract class MemoryTrackingNode<Row> extends AbstractNode<Row> {
+    /** Estimated overhead of row in hash map (assuming key and value is an objects composed from the original row fields). */
+    protected static final long HASH_MAP_ROW_OVERHEAD = ObjectSizeCalculator.OBJ_REF_SIZE * 4 / 3 /* load factor */ +
+        ObjectSizeCalculator.HASH_MAP_ENTRY_SIZE;
+
+    /** Estimated overhead of row in array (assuming overhead is only size of extra reference to the row). */
+    protected static final long ARRAY_ROW_OVERHEAD = ObjectSizeCalculator.OBJ_REF_SIZE;
+
+    /** Default row overhead (assuming rows are stored in arrays by default). */
+    protected static final long DFLT_ROW_OVERHEAD = ARRAY_ROW_OVERHEAD;
+
+    /** Memory tracker for the current execution node. */
+    protected final RowTracker<Row> nodeMemoryTracker;
+
+    /**
+     * @param ctx Execution context.
+     * @param rowType Row type.
+     * @param rowOverhead Row overhead in bytes for each row.
+     */
+    protected MemoryTrackingNode(ExecutionContext<Row> ctx, RelDataType rowType, long rowOverhead) {
+        super(ctx, rowType);
+
+        nodeMemoryTracker = ctx.createNodeMemoryTracker(rowOverhead);
+    }
+
+    /** */
+    protected MemoryTrackingNode(ExecutionContext<Row> ctx, RelDataType rowType) {
+        this(ctx, rowType, DFLT_ROW_OVERHEAD);
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void closeInternal() {
+        nodeMemoryTracker.reset();;

Review Comment:
   Extra unneeded semicolon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org