You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/08/23 21:55:41 UTC

[PR] Does all session clean up for normal scans [accumulo]

keith-turner opened a new pull request, #4826:
URL: https://github.com/apache/accumulo/pull/4826

   Normals scans were not running all session cleanup code like batch scans were.  AFAICT this change does not impact tablet severs and only scan severs.  The code that was not being called only seems to do some clean up on scan severs.  Following the code this change should cause SnapshotTablet.close() to be called now when a normal scan session is cleaned up on a scan server.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Does all session clean up for normal scans [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4826:
URL: https://github.com/apache/accumulo/pull/4826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Does all session clean up for normal scans [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4826:
URL: https://github.com/apache/accumulo/pull/4826#issuecomment-2308448383

   > LGTM, I agree it looks to only impact scan servers. Is this change related to https://github.com/apache/accumulo/issues/4757? Just curious if you think this will help with that or just something you noticed while in the code.
   
   It was just a general problem I noticed while working on the zombie scan metrics.  It might help with that, not sure yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org