[GitHub] [arrow-rs] Dandandan commented on a change in pull request #1324: Enable dead_code lint

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808432653



##########
File path: arrow/src/csv/reader.rs
##########
@@ -1055,6 +1056,7 @@ pub struct ReaderBuilder {
     /// The default batch size when using the `ReaderBuilder` is 1024 records
     batch_size: usize,
     /// The bounds over which to scan the reader. `None` starts from 0 and runs until EOF.
+    #[allow(dead_code)]

Review comment:
       Is this a bug?

##########
File path: arrow/src/csv/writer.rs
##########
@@ -97,6 +97,7 @@ pub struct Writer<W: Write> {
     /// The object to write to
     writer: csv_crate::Writer<W>,
     /// Column delimiter. Defaults to `b','`
+    #[allow(dead_code)]

Review comment:
       This seems a bug (not to use the delimiter option) . I think we should add a note or fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org