You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/05/16 16:48:31 UTC

Review Request 21556: Rpm type in metainfo.xml confusing on Ubuntu

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21556/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5789
    https://issues.apache.org/jira/browse/AMBARI-5789


Repository: ambari


Description
-------


    
                <package>
                  <type>rpm</type>
                  <name>hadoop</name>
                </package>
    

The tag "type" is not used at all, but this is confusing, when we add packages
that are common for ubuntu and rhel/suse, it's atcually can be deb or rpm


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java e317ece 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/metainfo.xml a13a56e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/metainfo.xml 21f0de9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/metainfo.xml cad0f55 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/metainfo.xml 8d1b9b9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/metainfo.xml 21949c4 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/metainfo.xml e6cd199 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/metainfo.xml 4121867 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/metainfo.xml 327c6d8 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/metainfo.xml 78703e9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/metainfo.xml 211551b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml 8e3dca0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/metainfo.xml 1107087 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 6842c38 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 63f3968 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 2d90f52 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml 35c9d9d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml b56bb49 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/metainfo.xml c8a3cf4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/metainfo.xml 50e3e77 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/metainfo.xml 63cff93 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 87619dd 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 51f4a16 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/metainfo.xml 629893d 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/metainfo.xml 61b32a1 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml 1126873 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 860aa6b 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml 1d203ea 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metainfo.xml df7d69f 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/metainfo.xml dd574bf 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/metainfo.xml 8f51a93 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/metainfo.xml 9a3ea37 
  ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 65ddc69 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml d396a58 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml 487c88b 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml f990385 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml 160a603 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml 5e350eb 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml 7820223 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml 67ac448 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml 327c6d8 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml 78703e9 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml c43972d 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/NAGIOS/metainfo.xml 3a06b91 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/metainfo.xml b5b7667 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metainfo.xml 7f718d3 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/metainfo.xml 4d19497 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/ZOOKEEPER/metainfo.xml 51f4a16 
  ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metainfo.xml 9c91971 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metainfo.xml b285bad 

Diff: https://reviews.apache.org/r/21556/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 21556: Rpm type in metainfo.xml confusing on Ubuntu

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21556/#review43210
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On May 16, 2014, 2:48 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21556/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 2:48 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5789
>     https://issues.apache.org/jira/browse/AMBARI-5789
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
>     
>                 <package>
>                   <type>rpm</type>
>                   <name>hadoop</name>
>                 </package>
>     
> 
> The tag "type" is not used at all, but this is confusing, when we add packages
> that are common for ubuntu and rhel/suse, it's atcually can be deb or rpm
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java e317ece 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/metainfo.xml a13a56e 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/metainfo.xml 21f0de9 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/metainfo.xml cad0f55 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/metainfo.xml 8d1b9b9 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/metainfo.xml 21949c4 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/metainfo.xml e6cd199 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/metainfo.xml 4121867 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/metainfo.xml 327c6d8 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/metainfo.xml 78703e9 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/metainfo.xml 211551b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml 8e3dca0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/metainfo.xml 1107087 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 6842c38 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 63f3968 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 2d90f52 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml 35c9d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml b56bb49 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/metainfo.xml c8a3cf4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/metainfo.xml 50e3e77 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/metainfo.xml 63cff93 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 87619dd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 51f4a16 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/metainfo.xml 629893d 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/metainfo.xml 61b32a1 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml 1126873 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/metainfo.xml 860aa6b 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml 1d203ea 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metainfo.xml df7d69f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/metainfo.xml dd574bf 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/metainfo.xml 8f51a93 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/metainfo.xml 9a3ea37 
>   ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 65ddc69 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml d396a58 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml 487c88b 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml f990385 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml 160a603 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml 5e350eb 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml 7820223 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml 67ac448 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml 327c6d8 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml 78703e9 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml c43972d 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/NAGIOS/metainfo.xml 3a06b91 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/metainfo.xml b5b7667 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metainfo.xml 7f718d3 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/metainfo.xml 4d19497 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/ZOOKEEPER/metainfo.xml 51f4a16 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metainfo.xml 9c91971 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metainfo.xml b285bad 
> 
> Diff: https://reviews.apache.org/r/21556/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>